netdev - Re: [PATCH net] gve: Add counter adminq_get_ptype_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240322130920.GF372561@kernel.org>
Date: Fri, 22 Mar 2024 13:09:20 +0000
From: Simon Horman <horms@...nel.org>
To: John Fraker <jfraker@...gle.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net] gve: Add counter adminq_get_ptype_map_cnt to stats
 report

On Thu, Mar 21, 2024 at 03:20:20PM -0700, John Fraker wrote:
> This counter counts the number of times get_ptype_map is executed on the
> admin queue, and was previously missing from the stats report.
> 
> Fixes: c4b87ac87635 ("gve: Add support for DQO RX PTYPE map")
> Signed-off-by: John Fraker <jfraker@...gle.com>

Hi John,

I'm fine with this patch but it feels more like an enhancement
for net-next than a fix for net.

If so, please drop the Fixes tag and repost next week after
net-next has reopened.

> ---
>  drivers/net/ethernet/google/gve/gve_ethtool.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c
> index 9aebfb843..dbe05402d 100644
> --- a/drivers/net/ethernet/google/gve/gve_ethtool.c
> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
> @@ -73,7 +73,7 @@ static const char gve_gstrings_adminq_stats[][ETH_GSTRING_LEN] = {
>  	"adminq_create_tx_queue_cnt", "adminq_create_rx_queue_cnt",
>  	"adminq_destroy_tx_queue_cnt", "adminq_destroy_rx_queue_cnt",
>  	"adminq_dcfg_device_resources_cnt", "adminq_set_driver_parameter_cnt",
> -	"adminq_report_stats_cnt", "adminq_report_link_speed_cnt"
> +	"adminq_report_stats_cnt", "adminq_report_link_speed_cnt", "adminq_get_ptype_map_cnt"

If you do repost, please consider reformatting this so the lines
remain no longer than 80 characters.

>  };
>  
>  static const char gve_gstrings_priv_flags[][ETH_GSTRING_LEN] = {
> @@ -428,6 +428,7 @@ gve_get_ethtool_stats(struct net_device *netdev,
>  	data[i++] = priv->adminq_set_driver_parameter_cnt;
>  	data[i++] = priv->adminq_report_stats_cnt;
>  	data[i++] = priv->adminq_report_link_speed_cnt;
> +	data[i++] = priv->adminq_get_ptype_map_cnt;
>  }
>  
>  static void gve_get_channels(struct net_device *netdev,
> -- 
> 2.44.0.291.gc1ea87d7ee-goog
> 
>