netdev - Re: [PATCH iproute2-next v2 0/2] bridge: vlan: add compressvlans manpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 Mar 2024 14:58:25 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Date Huang <tjjh89017@...mail.com>, roopa@...dia.com, jiri@...nulli.us
Cc: netdev@...r.kernel.org, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH iproute2-next v2 0/2] bridge: vlan: add compressvlans
 manpage

On 3/22/24 14:39, Date Huang wrote:
> Hi maintainers
> 
> I followed Nikolay and Jiri's comment and updated the patch to v2.
> Please check it.
> 

Your cover letter should contain an overview of what the set is doing.

> Date Huang (2):
>    bridge: vlan: fix compressvlans usage
>    bridge: vlan: add compressvlans manpage
> 
>   bridge/bridge.c   | 2 +-
>   man/man8/bridge.8 | 6 ++++++
>   2 files changed, 7 insertions(+), 1 deletion(-)
> 

Generally it is good to give people time to review and wait at least
24 hours before reposting another version. Also please write the
changes between versions, something like:

v3: ...
v2: split the patch into two separate patches
     changed the option in patch 01
     changed the man page description in patch 02

Keep the history from previous postings. Also you can note what changed
in each individual patch for the version under the first ---, for 
example for patch 02:
---
v2: changed the man page description

Cheers,
  Nik