netdev - Re: [PATCH 4/9] USB: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42c445b4-a156-4c43-bf98-bd2a9ac7a4fa@rowland.harvard.edu>
Date: Wed, 27 Mar 2024 13:55:00 -0400
From: Alan Stern <stern@...land.harvard.edu>
To: Allen Pais <apais@...ux.microsoft.com>
Cc: linux-kernel@...r.kernel.org, tj@...nel.org, keescook@...omium.org,
  vkoul@...nel.org, marcan@...can.st, sven@...npeter.dev,
  florian.fainelli@...adcom.com, rjui@...adcom.com, sbranden@...adcom.com,
  paul@...pouillou.net, Eugeniy.Paltsev@...opsys.com,
  manivannan.sadhasivam@...aro.org, vireshk@...nel.org, Frank.Li@....com,
  leoyang.li@....com, zw@...kernel.org, wangzhou1@...ilicon.com,
  haijie1@...wei.com, shawnguo@...nel.org, s.hauer@...gutronix.de,
  sean.wang@...iatek.com, matthias.bgg@...il.com,
  angelogioacchino.delregno@...labora.com, afaerber@...e.de,
  logang@...tatee.com, daniel@...que.org, haojian.zhuang@...il.com,
  robert.jarzmik@...e.fr, andersson@...nel.org, konrad.dybcio@...aro.org,
  orsonzhai@...il.com, baolin.wang@...ux.alibaba.com, zhang.lyra@...il.com,
  patrice.chotard@...s.st.com, linus.walleij@...aro.org, wens@...e.org,
  jernej.skrabec@...il.com, peter.ujfalusi@...il.com, kys@...rosoft.com,
  haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
  jassisinghbrar@...il.com, mchehab@...nel.org, maintainers@...echerrydvr.com,
  aubin.constans@...rochip.com, ulf.hansson@...aro.org,
  manuel.lauss@...il.com, mirq-linux@...e.qmqm.pl, jh80.chung@...sung.com,
  oakad@...oo.com, hayashi.kunihiko@...ionext.com, mhiramat@...nel.org,
  brucechang@....com.tw, HaraldWelte@...tech.com, pierre@...man.eu,
  duncan.sands@...e.fr, oneukum@...e.com,
  openipmi-developer@...ts.sourceforge.net, dmaengine@...r.kernel.org,
  asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
  linux-rpi-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
  imx@...ts.linux.dev, linuxppc-dev@...ts.ozlabs.org,
  linux-mediatek@...ts.infradead.org, linux-actions@...ts.infradead.org,
  linux-arm-msm@...r.kernel.org, linux-riscv@...ts.infradead.org,
  linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
  linux-hyperv@...r.kernel.org, linux-rdma@...r.kernel.org,
  linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
  linux-omap@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
  linux-s390@...r.kernel.org, netdev@...r.kernel.org,
  linux-usb@...r.kernel.org
Subject: Re: [PATCH 4/9] USB: Convert from tasklet to BH workqueue

On Wed, Mar 27, 2024 at 04:03:09PM +0000, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
> 
> This patch converts drivers/infiniband/* from tasklet to BH workqueue.
> 
> Based on the work done by Tejun Heo <tj@...nel.org>
> Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10
> 
> Signed-off-by: Allen Pais <allen.lkml@...il.com>
> ---

> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index c0e005670d67..88d8e1c366cd 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c

> @@ -1662,10 +1663,9 @@ static void __usb_hcd_giveback_urb(struct urb *urb)
>  	usb_put_urb(urb);
>  }
>  
> -static void usb_giveback_urb_bh(struct work_struct *work)
> +static void usb_giveback_urb_bh(struct work_struct *t)
>  {
> -	struct giveback_urb_bh *bh =
> -		container_of(work, struct giveback_urb_bh, bh);
> +	struct giveback_urb_bh *bh = from_work(bh, t, bh);
>  	struct list_head local_list;
>  
>  	spin_lock_irq(&bh->lock);

Is there any reason for this apparently pointless change of a local
variable's name?

Alan Stern