lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOMdWSLipPfm3OZTpjZz4uF4M+E_8QAoTeMcKBXawLnkTQx6Jg@mail.gmail.com>
Date: Wed, 27 Mar 2024 09:58:12 -0700
From: Allen <allen.lkml@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Allen Pais <apais@...ux.microsoft.com>, linux-kernel@...r.kernel.org, tj@...nel.org, 
	keescook@...omium.org, vkoul@...nel.org, marcan@...can.st, sven@...npeter.dev, 
	florian.fainelli@...adcom.com, rjui@...adcom.com, sbranden@...adcom.com, 
	paul@...pouillou.net, Eugeniy.Paltsev@...opsys.com, 
	manivannan.sadhasivam@...aro.org, vireshk@...nel.org, Frank.Li@....com, 
	leoyang.li@....com, zw@...kernel.org, wangzhou1@...ilicon.com, 
	haijie1@...wei.com, shawnguo@...nel.org, s.hauer@...gutronix.de, 
	sean.wang@...iatek.com, matthias.bgg@...il.com, 
	angelogioacchino.delregno@...labora.com, afaerber@...e.de, 
	logang@...tatee.com, daniel@...que.org, haojian.zhuang@...il.com, 
	robert.jarzmik@...e.fr, andersson@...nel.org, konrad.dybcio@...aro.org, 
	orsonzhai@...il.com, baolin.wang@...ux.alibaba.com, zhang.lyra@...il.com, 
	patrice.chotard@...s.st.com, linus.walleij@...aro.org, wens@...e.org, 
	jernej.skrabec@...il.com, peter.ujfalusi@...il.com, kys@...rosoft.com, 
	haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com, 
	jassisinghbrar@...il.com, mchehab@...nel.org, maintainers@...echerrydvr.com, 
	aubin.constans@...rochip.com, ulf.hansson@...aro.org, manuel.lauss@...il.com, 
	mirq-linux@...e.qmqm.pl, jh80.chung@...sung.com, oakad@...oo.com, 
	hayashi.kunihiko@...ionext.com, mhiramat@...nel.org, brucechang@....com.tw, 
	HaraldWelte@...tech.com, pierre@...man.eu, duncan.sands@...e.fr, 
	stern@...land.harvard.edu, oneukum@...e.com, 
	openipmi-developer@...ts.sourceforge.net, dmaengine@...r.kernel.org, 
	asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-rpi-kernel@...ts.infradead.org, linux-mips@...r.kernel.org, 
	imx@...ts.linux.dev, linuxppc-dev@...ts.ozlabs.org, 
	linux-mediatek@...ts.infradead.org, linux-actions@...ts.infradead.org, 
	linux-arm-msm@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org, 
	linux-hyperv@...r.kernel.org, linux-rdma@...r.kernel.org, 
	linux-media@...r.kernel.org, linux-mmc@...r.kernel.org, 
	linux-omap@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-s390@...r.kernel.org, netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 4/9] USB: Convert from tasklet to BH workqueue

> > The only generic interface to execute asynchronously in the BH context is
> > tasklet; however, it's marked deprecated and has some design flaws. To
> > replace tasklets, BH workqueue support was recently added. A BH workqueue
> > behaves similarly to regular workqueues except that the queued work items
> > are executed in the BH context.
> >
> > This patch converts drivers/infiniband/* from tasklet to BH workqueue.
>
> No it does not, I think your changelog is wrong :(

Whoops, sorry about that. I messed up the commit messages. I will fix it in v2.
>
> >
> > Based on the work done by Tejun Heo <tj@...nel.org>
> > Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10
> >
> > Signed-off-by: Allen Pais <allen.lkml@...il.com>
> > ---
> >  drivers/usb/atm/usbatm.c            | 55 +++++++++++++++--------------
> >  drivers/usb/atm/usbatm.h            |  3 +-
> >  drivers/usb/core/hcd.c              | 22 ++++++------
> >  drivers/usb/gadget/udc/fsl_qe_udc.c | 21 +++++------
> >  drivers/usb/gadget/udc/fsl_qe_udc.h |  4 +--
> >  drivers/usb/host/ehci-sched.c       |  2 +-
> >  drivers/usb/host/fhci-hcd.c         |  3 +-
> >  drivers/usb/host/fhci-sched.c       | 10 +++---
> >  drivers/usb/host/fhci.h             |  5 +--
> >  drivers/usb/host/xhci-dbgcap.h      |  3 +-
> >  drivers/usb/host/xhci-dbgtty.c      | 15 ++++----
> >  include/linux/usb/cdc_ncm.h         |  2 +-
> >  include/linux/usb/usbnet.h          |  2 +-
> >  13 files changed, 76 insertions(+), 71 deletions(-)
> >
> > diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
> > index 2da6615fbb6f..74849f24e52e 100644
> > --- a/drivers/usb/atm/usbatm.c
> > +++ b/drivers/usb/atm/usbatm.c
> > @@ -17,7 +17,7 @@
> >   *           - Removed the limit on the number of devices
> >   *           - Module now autoloads on device plugin
> >   *           - Merged relevant parts of sarlib
> > - *           - Replaced the kernel thread with a tasklet
> > + *           - Replaced the kernel thread with a work
>
> a "work"?
 will fix the comments.

>
> >   *           - New packet transmission code
> >   *           - Changed proc file contents
> >   *           - Fixed all known SMP races
> > @@ -68,6 +68,7 @@
> >  #include <linux/wait.h>
> >  #include <linux/kthread.h>
> >  #include <linux/ratelimit.h>
> > +#include <linux/workqueue.h>
> >
> >  #ifdef VERBOSE_DEBUG
> >  static int usbatm_print_packet(struct usbatm_data *instance, const unsigned char *data, int len);
> > @@ -249,7 +250,7 @@ static void usbatm_complete(struct urb *urb)
> >       /* vdbg("%s: urb 0x%p, status %d, actual_length %d",
> >            __func__, urb, status, urb->actual_length); */
> >
> > -     /* Can be invoked from task context, protect against interrupts */
> > +     /* Can be invoked from work context, protect against interrupts */
>
> "workqueue"?  This too seems wrong.
>
> Same for other comment changes in this patch.

Thanks for the quick review, I will fix the comments and send out v2.

- Alle

> thanks,
>
> greg k-h
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ