netdev - Re: [PATCH net-next] tcp/dccp: bypass empty buckets in inet_twsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240329080648.3cd12eaf@kernel.org>
Date: Fri, 29 Mar 2024 08:06:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: <edumazet@...gle.com>, <davem@...emloft.net>, <eric.dumazet@...il.com>,
 <netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next] tcp/dccp: bypass empty buckets in
 inet_twsk_purge()

On Wed, 27 Mar 2024 12:29:34 -0700 Kuniyuki Iwashima wrote:
> > -	for (slot = 0; slot <= hashinfo->ehash_mask; slot++) {
> > -		struct inet_ehash_bucket *head = &hashinfo->ehash[slot];
> > +	for (slot = 0; slot <= ehash_mask; slot++, head++) {
> > +  
> 
> unnecessary blank link here.

I've seen some other core kernel contributors add empty lines after 
for or if statements, so I think this is intentional. Not sure why
the empty line helps, either, TBH, but we have been letting it slide 
so far.