netdev - Re: [PATCH net-next v2 2/3] net: ethtool: Add impedance mismatch result code to cable test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240329081058.15ee0f1d@kernel.org>
Date: Fri, 29 Mar 2024 08:10:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paweł Dembicki <paweldembicki@...il.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Stefan Eichenberger <eichest@...il.com>, Dimitri
 Fedrau <dima.fedrau@...il.com>, Kory Maincent <kory.maincent@...tlin.com>,
 Maxime Chevallier <maxime.chevallier@...tlin.com>, Shay Agroskin
 <shayagr@...zon.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: ethtool: Add impedance mismatch
 result code to cable test

On Fri, 29 Mar 2024 10:31:10 +0100 Paweł Dembicki wrote:
> > I'm not a cable expert but going purely by the language
> > abnormal != mismatch. Mismatch indicates there are two
> > values we are comparing.  
> 
> Impedance mismatch can be detected because some parts of the cable may
> have different (abnormal) impedance, causing reflections at those
> points. Ethernet cables should have a characteristic impedance of 100
> Ohms, so any mismatch from this value is considered abnormal.

I see, makes sense.

> I can provide a rephrased version if the commit description was not
> detailed enough.

That'd be great. Or maybe even better a short comment above the enum
entry?