netdev - Re: [Intel-wired-lan] [PATCH iwl-next v2 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba809a2a-3850-27ab-5836-f6705150f0a4@intel.com>
Date: Fri, 29 Mar 2024 13:46:44 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Mateusz Polchlopek <mateusz.polchlopek@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: Jacob Keller <jacob.e.keller@...el.com>, <netdev@...r.kernel.org>,
	Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 09/12] iavf: refactor
 iavf_clean_rx_irq to support legacy and flex descriptors

On 3/27/2024 6:25 AM, Mateusz Polchlopek wrote:

...

> diff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> index b71484c87a84..c9c4f255bc8b 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_txrx.c

...

>   /**
> - * iavf_rx_checksum - Indicate in skb if hw indicated a good cksum
> + * iavf_rx_csum - Indicate in skb if hw indicated a good checksum
>    * @vsi: the VSI we care about
>    * @skb: skb currently being received and modified
> - * @rx_desc: the receive descriptor
> + * @ptype: decoded ptype information
> + * @csum_bits: decoded Rx descriptor information
>    **/
> -static void iavf_rx_checksum(struct iavf_vsi *vsi,
> -			     struct sk_buff *skb,
> -			     union iavf_rx_desc *rx_desc)
> +static inline void iavf_rx_csum(struct iavf_vsi *vsi, struct sk_buff *skb,

Please don't use 'inline' in c files. More usages throughout this patch 
as well.

> +				struct iavf_rx_ptype_decoded *ptype,
> +				struct iavf_rx_csum_decoded *csum_bits)
>   {