| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ba809a2a-3850-27ab-5836-f6705150f0a4@intel.com>
Date: Fri, 29 Mar 2024 13:46:44 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Mateusz Polchlopek <mateusz.polchlopek@...el.com>,
<intel-wired-lan@...ts.osuosl.org>
CC: Jacob Keller <jacob.e.keller@...el.com>, <netdev@...r.kernel.org>,
Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 09/12] iavf: refactor
iavf_clean_rx_irq to support legacy and flex descriptors
On 3/27/2024 6:25 AM, Mateusz Polchlopek wrote:
...
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> index b71484c87a84..c9c4f255bc8b 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
...
> /**
> - * iavf_rx_checksum - Indicate in skb if hw indicated a good cksum
> + * iavf_rx_csum - Indicate in skb if hw indicated a good checksum
> * @vsi: the VSI we care about
> * @skb: skb currently being received and modified
> - * @rx_desc: the receive descriptor
> + * @ptype: decoded ptype information
> + * @csum_bits: decoded Rx descriptor information
> **/
> -static void iavf_rx_checksum(struct iavf_vsi *vsi,
> - struct sk_buff *skb,
> - union iavf_rx_desc *rx_desc)
> +static inline void iavf_rx_csum(struct iavf_vsi *vsi, struct sk_buff *skb,
Please don't use 'inline' in c files. More usages throughout this patch
as well.
> + struct iavf_rx_ptype_decoded *ptype,
> + struct iavf_rx_csum_decoded *csum_bits)
> {
X-sender: <netdev+bounces-83460-steffen.klassert=secunet.com@...r.kernel.org>
X-Receiver: <steffen.klassert@...unet.com> ORCPT=rfc822;steffen.klassert@...unet.com; X-ExtendedProps=DwA1AAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5EaXJlY3RvcnlEYXRhLklzUmVzb3VyY2UCAAAFABUAFgACAAAABQAUABEA8MUJLbkECUOS0gjaDTZ+uAUAagAJAAEAAAAAAAAABQAWAAIAAAUAQwACAAAFAEYABwADAAAABQBHAAIAAAUAEgAPAGIAAAAvbz1zZWN1bmV0L291PUV4Y2hhbmdlIEFkbWluaXN0cmF0aXZlIEdyb3VwIChGWURJQk9IRjIzU1BETFQpL2NuPVJlY2lwaWVudHMvY249U3RlZmZlbiBLbGFzc2VydDY4YwUACwAXAL4AAACheZxkHSGBRqAcAp3ukbifQ049REI2LENOPURhdGFiYXNlcyxDTj1FeGNoYW5nZSBBZG1pbmlzdHJhdGl2ZSBHcm91cCAoRllESUJPSEYyM1NQRExUKSxDTj1BZG1pbmlzdHJhdGl2ZSBHcm91cHMsQ049c2VjdW5ldCxDTj1NaWNyb3NvZnQgRXhjaGFuZ2UsQ049U2VydmljZXMsQ049Q29uZmlndXJhdGlvbixEQz1zZWN1bmV0LERDPWRlBQAOABEABiAS9uuMOkqzwmEZDvWNNQUAHQAPAAwAAABtYngtZXNzZW4tMDIFADwAAgAADwA2AAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5NYWlsUmVjaXBpZW50LkRpc3BsYXlOYW1lDwARAAAAS2xhc3NlcnQsIFN0ZWZmZW4FAGwAAgAABQBYABcASgAAAPDFCS25BAlDktII2g02frhDTj1LbGFzc2VydCBTdGVmZmVuLE9VPVVzZXJzLE9VPU1pZ3JhdGlvbixEQz1zZWN1bmV0LERDPWRlBQAMAAIAAAUAJgACAAEFACIADwAxAAAAQXV0b1Jlc3BvbnNlU3VwcHJlc3M6IDANClRyYW5zbWl0SGlzdG9yeTogRmFsc2UNCg8ALwAAAE1pY3Jvc29mdC5FeGNoYW5nZS5UcmFuc3BvcnQuRXhwYW5zaW9uR3JvdXBUeXBlDwAVAAAATWVtYmVyc0dyb3VwRXhwYW5zaW9uBQAjAAIAAQ==
X-CreatedBy: MSExchange15
X-HeloDomain: b.mx.secunet.com
X-ExtendedProps: BQBjAAoAG0amlidQ3AgFAGEACAABAAAABQA3AAIAAA8APAAAAE1pY3Jvc29mdC5FeGNoYW5nZS5UcmFuc3BvcnQuTWFpbFJlY2lwaWVudC5Pcmdhbml6YXRpb25TY29wZREAAAAAAAAAAAAAAAAAAAAAAAUASQACAAEFAAQAFCABAAAAHAAAAHN0ZWZmZW4ua2xhc3NlcnRAc2VjdW5ldC5jb20FAAYAAgABDwAqAAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5SZXN1Ym1pdENvdW50BwACAAAADwAJAAAAQ0lBdWRpdGVkAgABBQACAAcAAQAAAAUAAwAHAAAAAAAFAAUAAgABBQBiAAoAqgAAAMuKAAAFAGQADwADAAAASHViBQApAAIAAQ8APwAAAE1pY3Jvc29mdC5FeGNoYW5nZS5UcmFuc3BvcnQuRGlyZWN0b3J5RGF0YS5NYWlsRGVsaXZlcnlQcmlvcml0eQ8AAwAAAExvdw==
X-Source: SMTP:Default MBX-ESSEN-02
X-SourceIPAddress: 62.96.220.37
X-EndOfInjectedXHeaders: 19255
Received: from cas-essen-02.secunet.de (10.53.40.202) by
mbx-essen-02.secunet.de (10.53.40.198) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.37; Fri, 29 Mar 2024 21:47:02 +0100
Received: from b.mx.secunet.com (62.96.220.37) by cas-essen-02.secunet.de
(10.53.40.202) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend
Transport; Fri, 29 Mar 2024 21:47:02 +0100
Received: from localhost (localhost [127.0.0.1])
by b.mx.secunet.com (Postfix) with ESMTP id 05EC92032C
for <steffen.klassert@...unet.com>; Fri, 29 Mar 2024 21:47:02 +0100 (CET)
X-Virus-Scanned: by secunet
X-Spam-Flag: NO
X-Spam-Score: -5.763
X-Spam-Level:
X-Spam-Status: No, score=-5.763 tagged_above=-999 required=2.1
tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.099, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
HEADER_FROM_DIFFERENT_DOMAINS=0.249, MAILING_LIST_MULTI=-1,
NICE_REPLY_A=-2.913, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: a.mx.secunet.com (amavisd-new);
dkim=pass (2048-bit key) header.d=intel.com
Received: from b.mx.secunet.com ([127.0.0.1])
by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id CZvrqQk9JdDT for <steffen.klassert@...unet.com>;
Fri, 29 Mar 2024 21:46:58 +0100 (CET)
Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=147.75.199.223; helo=ny.mirrors.kernel.org; envelope-from=netdev+bounces-83460-steffen.klassert=secunet.com@...r.kernel.org; receiver=steffen.klassert@...unet.com
DKIM-Filter: OpenDKIM Filter v2.11.0 b.mx.secunet.com 4C5E420270
Authentication-Results: b.mx.secunet.com;
dkim=pass (2048-bit key) header.d=intel.com header.i=@...el.com header.b="N7w9qkGK"
Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by b.mx.secunet.com (Postfix) with ESMTPS id 4C5E420270
for <steffen.klassert@...unet.com>; Fri, 29 Mar 2024 21:46:58 +0100 (CET)
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by ny.mirrors.kernel.org (Postfix) with ESMTPS id 533441C20EDA
for <steffen.klassert@...unet.com>; Fri, 29 Mar 2024 20:46:57 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A6F258127;
Fri, 29 Mar 2024 20:46:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=intel.com header.i=@...el.com header.b="N7w9qkGK"
X-Original-To: netdev@...r.kernel.org
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EA103BB2A
for <netdev@...r.kernel.org>; Fri, 29 Mar 2024 20:46:50 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.16
ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1711745212; cv=fail; b=EPPgqq0/xVCZJIN8n8jxFRo2LU4hOL5RED3tgLYBNs5IviTRzHenveHox8DAIqGGYZGrab/mUHE4RbKGnuKr6Kkk3zUSL+W+VDWQ2frPHSLzMTW0pZd+qXdSQIPhowCVR38J2feSqqMvTxTtznYVhSuQkmemp9/YTKW/rS6STU8=
ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1711745212; c=relaxed/simple;
bh=T0W/vcVcQMWX87w1VyY2NuTB5lHo0SBiBl0eXikknTo=;
h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To:
Content-Type:MIME-Version; b=ihm8naKikxtjV14wGHvXLAfLrnHHBS0x7g19Yzo+ljucn/OufFjEWGcxVcGZzZdXP0zJBfPXx51JcMGBbdvLbzCJoMs1Xo91z5ekuAzoMJXczJNpnMwViYgfsstbEj/gjyDDFjEXy3wSNxWIbX5Qptk1TpNdSUKXo0ssEPpLkGU=
ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@...el.com header.b=N7w9qkGK; arc=fail smtp.client-ip=198.175.65.16
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@...el.com; q=dns/txt; s=Intel;
t=1711745211; x=1743281211;
h=message-id:date:subject:to:cc:references:from:
in-reply-to:content-transfer-encoding:mime-version;
bh=T0W/vcVcQMWX87w1VyY2NuTB5lHo0SBiBl0eXikknTo=;
b=N7w9qkGKbxGElbVR6cggyhMh1Uu08DXnri3RgTCzhXHFDcUvp4a8jBjY
G2o3hwpMaXqaMSRRBssVFjyDPOZkRjrBE75I+mr2NOUxJCu/IJPgTxMTo
KQBDTXQAoHB9xVhYoKVJ7mIpsjff30Qvofp4q5kuYfqu5B0T/Lggoicbv
WcnaDw2DtNx8BX+8efPqvRLqg4sA68tHlTvgn1/cGoWhTH6BhCFCyIXmH
vZHWmEiHa3K8Odae+057OJIQAxmkabaesbw1z2889A0uPAufCzLqCsYgY
UVxP8Up77PYD/0dy99AvVMU7ERJDBL+J2GH9G8U5hhrR4Qsid58X5U8KF
w==;
X-CSE-ConnectionGUID: hF85gnBIRvqL0aqa14TKwQ==
X-CSE-MsgGUID: M+6GhsIzScOUgzA8Wo5nDw==
X-IronPort-AV: E=McAfee;i="6600,9927,11028"; a="7062625"
X-IronPort-AV: E=Sophos;i="6.07,165,1708416000";
d="scan'208";a="7062625"
Received: from orviesa009.jf.intel.com ([10.64.159.149])
by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2024 13:46:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.07,165,1708416000";
d="scan'208";a="17056286"
Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16])
by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Mar 2024 13:46:50 -0700
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.35; Fri, 29 Mar 2024 13:46:49 -0700
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.35 via Frontend Transport; Fri, 29 Mar 2024 13:46:49 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169)
by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.35; Fri, 29 Mar 2024 13:46:49 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=TOw77p6bDHulD1sUgk2apPvNvQqlPbVPNUvZeS+JWW4Pp3CBgVmxzUnLXgAFuhWtTYv/kVmT5pg8PJyTKaGycVEViXIkEugHGxeOOXFGqO1vapRpUT4Dj1vGwBmN/Yqe/W8Y18XXAKKyG0KNrFNebRQyymgH1txZy+PgjLwayQYCNKNuH+UGG01L6pynkCDDnfnh2yUiGRmYymmmqp/sXZy/ngTF5gxymAwuvI7i15gzxi7vk1kYfGO+cQQ5GbgK4DqrzlqE3E49ZvQHnkdr1Lqt44+75PEzhiVXv9kc8A6Fl2VrdiYXl1p2WZxjf33icDEEZIBMxkJevBzQZFwUMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=CX2vHtBbI9qqg/q0TRV1qETrkmc07CDFL0CyPCDq3J0=;
b=mGrMNqv4ysPSmgN7wEYqNcTNEc+pI7GcyR07j3ryYrqEXiRIQwyamSmabnE/RT6N6oIO/7QQec9dJ/XFd8iLkn2Eep5kro7b+x152dYLzPkEWSDnGjYPb5iwmGzlntyAK7gY7DOWDMg0gwwIWSpcilSl9XiZY5+exJUvd1YFG2DQkVSYpxKpjpNPH7281JVvR6A/nHEQeNcvCtViVEcWgzcUDrE6hcDHJ7+fSHRv+ghCWcDIWcKtB9ZdQXchcVzTwq09gqWsU500XVfd+TrohUI5W7BQPE3zf0nBIM9gvT6IImBoC1548VeFov+DF42opgsJc5gt+PjXZgf5sGIOtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Received: from BL3PR11MB6435.namprd11.prod.outlook.com (2603:10b6:208:3bb::9)
by DS0PR11MB7190.namprd11.prod.outlook.com (2603:10b6:8:132::5) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.40; Fri, 29 Mar
2024 20:46:47 +0000
Received: from BL3PR11MB6435.namprd11.prod.outlook.com
([fe80::9c80:a200:48a2:b308]) by BL3PR11MB6435.namprd11.prod.outlook.com
([fe80::9c80:a200:48a2:b308%4]) with mapi id 15.20.7409.031; Fri, 29 Mar 2024
20:46:47 +0000
Message-ID: <ba809a2a-3850-27ab-5836-f6705150f0a4@...el.com>
Date: Fri, 29 Mar 2024 13:46:44 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
Thunderbird/102.6.1
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 09/12] iavf: refactor
iavf_clean_rx_irq to support legacy and flex descriptors
To: Mateusz Polchlopek <mateusz.polchlopek@...el.com>,
<intel-wired-lan@...ts.osuosl.org>
CC: Jacob Keller <jacob.e.keller@...el.com>, <netdev@...r.kernel.org>,
Wojciech Drewek <wojciech.drewek@...el.com>
References: <20240327132543.15923-1-mateusz.polchlopek@...el.com>
<20240327132543.15923-10-mateusz.polchlopek@...el.com>
Content-Language: en-US
From: Tony Nguyen <anthony.l.nguyen@...el.com>
In-Reply-To: <20240327132543.15923-10-mateusz.polchlopek@...el.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: MW4PR04CA0123.namprd04.prod.outlook.com
(2603:10b6:303:84::8) To BL3PR11MB6435.namprd11.prod.outlook.com
(2603:10b6:208:3bb::9)
Precedence: bulk
X-Mailing-List: netdev@...r.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@...r.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@...r.kernel.org>
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BL3PR11MB6435:EE_|DS0PR11MB7190:EE_
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aQR7gzJpvGbGWdczuueAUgY27xwKkg8DeTNUHRshyA2aJ/iufvOUrB6jU6Lmww/7ESr1N3BFc0+sGAdU1i8yWA1b1ggIEctXakPezyf6roOdskSUtpbdfMH5GznesFrqjiBCqK4lo/WtxhKxA/h+t/oemBxZ1m4tixQDVlcbPAV+bpweEL6Pht2paUox2YuYZdJ63mLB+RVHsPQ66tz8x5hBjKd6R5LRsFxzfGY/m8d/7RBoA1KFetcsqPGHTE4VGpRz1r8px6jZFyXObHGKQfJnD2Cus7OdIUeAyyvJod2hGJwgKReJW9sDTu2iuS9YR06zqS6221E1cEcyhCGAU16thBDo1r2TZHH+YGLepE7A9YDOuZ1QG0Q7mAfysvjNYxQUHfucbAX+BPz+VRVqdnxm8Z4sXJYaWSFzcmNQ8DXMlpRziV3Q2iDtoJTdCTC7qFwODFsycNkK+M7qDeVZGE/ZFjCYgLjkNGsNSg5rvorA1Ok8VtBeTWVZY2UGHH5kjbd+qd/QvgyYsqnzyjTPGbA5ESkTs47ObSDCy+vR0m3WuuRDoy18o6LgjJMpozSEYvlKYjApDc8W2RyHpSC1SYji5/Pd1F9EblK0MW2UDWJcRU9i1gv/XlfcPaR/wLYi9B8d9z6c5QegkNs5/alZ+w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL3PR11MB6435.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmJVZVMxZ0JSNDAwR0tEMms4WmhTNXMvSUlGM3RRWGdhQ0FSZHlLbUNINTJ0?=
=?utf-8?B?QjdiU0NQMVFGRVlkOEFpbW5FWkM0dEYrMVVlT1NIRThtd3o4UWZlT1Zrd0g2?=
=?utf-8?B?eGxUQ3NQby9zQzNqYmh2UU1HRzlXS1dsUDdjdkRENXNEM2xCTkdObEpXdHFz?=
=?utf-8?B?aFNxSFpvY0hlakRUZFFaNktQaWl5R3V4QlREQjhwVnE3Slhkci82WlErcWdE?=
=?utf-8?B?RW8yRUhqNWJwclBtWEt2YzZySEhadHdib0JEcGFHNUJKWDh4dFBhU044eE5J?=
=?utf-8?B?ZFB2Q0VMUDFEM3d0T3VYSmJMTStLSDNJQkxWYW1oYmpJK1NMNzNmLy9pSGxl?=
=?utf-8?B?WUFKQ1JQZWtrU1FNeExIMFJZU3FaMlo4ZHlUNkNxSGpZZk5QVFArUjRMQWRB?=
=?utf-8?B?cm43c0hheFdXZ3FsZmt5ZUYySGN0MlAxblJwQ1lWQldkRlllZTgySzFZQ1Iw?=
=?utf-8?B?MktsZ2pMbWFmRzNYV1k0cWdKNm9jTzVCZktqL3NBdjFqQmVDbUZVcDIwdWZQ?=
=?utf-8?B?dEhTdWNvdjNpUlQrUEF4dEY2WC9wRGx5NVRqSEJFbU1BNTlGL2Q0TkpSRUpZ?=
=?utf-8?B?c3grVlNxbGxNMDhqWWd3Mkg3bFlnTDJCVWpJNVo1QXJSTFd2QnF3WVVLeHJV?=
=?utf-8?B?ZEg4YTZaYjlESmE3L3FGN2k3STNaV3FmbHhjT3o3NDRrMFJUbWFqelk3Y1FP?=
=?utf-8?B?ZW9JVlM2YytIYWZJQXl0azlyZnNLUVRPT2o1Vm1VN0ZIY0dtYzd4RmdETGFr?=
=?utf-8?B?djJzaUdnR0d5dG5TNmplayszM3p0RXEvMzJ4TmFYdEZzT2MyOU4rNjc3WnpN?=
=?utf-8?B?dGZLNVZVSnBpQ21qTVhwdElCMFFxNE9GcTBuTFJ2dTB0cWpFRFB1U00yNXNz?=
=?utf-8?B?TzJjM0dOZjU4aWhyNmRVKzM5WllibFBtdWFJcHNjVHdSSlhKR1VHckdtck9X?=
=?utf-8?B?OUdIakk2blZ6dzViTDNaZVlJb2VTcUF6RXBtVVYxZ2poYit1VDRKb0w5TnFG?=
=?utf-8?B?LzZDaTlBbnpzeGc4U3lSRnRnZURub2NNYno3Y2M0YzJ3M0pET3NxZU5mNnBD?=
=?utf-8?B?cTUvSUh3cFJlbDRVUEJGN2Y2MUt4cGVITjZySFNWdXlsWHBtTEJaeHFBbGNo?=
=?utf-8?B?aDNwMWhmMDgzL2xMUTdNclZzdjJLSVpYMzRzamdVM0c0bkpudlNGbTlKVmhs?=
=?utf-8?B?TDZEd3gvZEo5ODZyM1o2Vm5XTE5BcDIwcmhzdVhTME83WFJaOG1TVVhOb0VU?=
=?utf-8?B?bHpjSkFpNlF5YTRveHdDWmdXMHlOTnZSWFFlNnk0UjRTSVNTK2p5ZVdUVHl4?=
=?utf-8?B?aERwRjdvYkFoOGNyVktEUUxWajJQWnUrU00wbzk2cTl0ZVBPSzh2a0ZCWkw3?=
=?utf-8?B?czBFbUoxNjJpeTU1T3dML2dtMmdhd2l5QjB4T2dLYkE0YmJtdkJoSGdlcWdV?=
=?utf-8?B?NlhodzZ4OFNsdjFUeHVtZnRjSElueVp6cktQeVB6ZFBDbi9JVW5kYXhFMEZL?=
=?utf-8?B?T0JxemwxdE1ScmFuNU9JMXRuZ2trMmdZdXoxRTI5WW9aTlQvQjF5RXBwOHM5?=
=?utf-8?B?RUhNMWl4aklVbndBYkNhZlVoem8wZWMxczluU3gydXZIdDdKQUVna2hqN3Vj?=
=?utf-8?B?Tld2U0pGY0FYWnBqMW9ZcU15ajhWd1pPZ2I5VSswSVZYRW8xSFN6T29SY255?=
=?utf-8?B?dXNRZVZhTTFCejJQNGJKWkFJazdGN1h5L3FSQldISUx6K0hkbUR3emUxUHIz?=
=?utf-8?B?UUViNUtBTk1WaUNmYngxdEZMQytTdXdHczFGMlpWUTdQYkFwRk9Pb25mR05t?=
=?utf-8?B?ZitaYlpZRFdleCt3cDkvRDRodCsrKzQzUUFJQytCeVNCWlFqNWZCOS8wdWk1?=
=?utf-8?B?dGhrSEI2R3FEQ3FkYkVYMWc2SS85akwwV3FVbFRvcXpwSndhWk0yVXpaUk1W?=
=?utf-8?B?MEdVSVk4Q29PUGl5TFBKOUV5SGllWW1hd0N5clhTZTQ1LzdNbzBiempKYkNy?=
=?utf-8?B?UnFFTXFQWHZUeG9nNTdGSG5XZlFlRjhJYSttVWpKVUkxRDFHSnlWNFdTRGhq?=
=?utf-8?B?WTNST0cvRFowcHhKZFM1T0RoZG5Oak51WDN2cWg5NEwyRDJEOEZFYzUvcGRD?=
=?utf-8?B?TzRWbVVneWxodm5wZFpDc3BiUTJBRUJRUTBIYXhmc0YyMFVwY1FKVmdBQWNY?=
=?utf-8?B?SXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 05c0ce0d-669b-4350-f9cc-08dc50315a0d
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6435.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 20:46:47.6218
(UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 42PuwosqQtAMyTcy9wYJ3OAdeZ4COjreAxG4pfD9oN7Sa/IJDQ9lwYU5Q7qepPoIElrYpoeP0FqpOWoLl726lzF8sCRUO5BJGjXOGP94JRM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7190
Return-Path: netdev+bounces-83460-steffen.klassert=secunet.com@...r.kernel.org
X-MS-Exchange-Organization-OriginalArrivalTime: 29 Mar 2024 20:47:02.0562
(UTC)
X-MS-Exchange-Organization-Network-Message-Id: 2d8ac8b2-453d-4069-c8ac-08dc503162c6
X-MS-Exchange-Organization-OriginalClientIPAddress: 62.96.220.37
X-MS-Exchange-Organization-OriginalServerIPAddress: 10.53.40.202
X-MS-Exchange-Organization-Cross-Premises-Headers-Processed: cas-essen-02.secunet.de
X-MS-Exchange-Organization-OrderedPrecisionLatencyInProgress: LSRV=mbx-essen-02.secunet.de:TOTAL-HUB=41523.287|SMR=0.134(SMRDE=0.005|SMRC=0.129(SMRCL=0.103|X-SMRCR=0.128))|CAT=0.041(CATRESL=0.022
(CATRESLP2R=0.018)|CATORES=0.017(CATRS=0.017(CATRS-Index Routing
Agent=0.015)))|QDM=3205.885
|SMSC=0.555(X-SMSDR=0.083)|SMS=5.943(SMSMBXD-INC=5.398)|QDM=8880.891|SMS=5.693(SMSMBXD-INC=5.264
)|QDM=16239.372|SMSC=0.022|SMS=3.842(SMSMBXD-INC=3.830)|QDM=13175.805|UNK=0.004|CAT=0.006
(CATRESL=0.004(CATRESLP2R=0.002))|QDM=5.388|CAT=0.020(CATRESL=0.019(CATRESLP2R=0.001
));2024-03-30T08:19:05.361Z
X-MS-Exchange-Forest-ArrivalHubServer: mbx-essen-02.secunet.de
X-MS-Exchange-Organization-AuthSource: cas-essen-02.secunet.de
X-MS-Exchange-Organization-AuthAs: Anonymous
X-MS-Exchange-Organization-FromEntityHeader: Internet
X-MS-Exchange-Organization-OriginalSize: 15867
X-MS-Exchange-Organization-HygienePolicy: Standard
X-MS-Exchange-Organization-MessageLatency: SRV=cas-essen-02.secunet.de:TOTAL-FE=0.016|SMR=0.009(SMRPI=0.006(SMRPI-FrontendProxyAgent=0.006))|SMS=0.008
X-MS-Exchange-Organization-Recipient-Limit-Verified: True
X-MS-Exchange-Organization-TotalRecipientCount: 1
X-MS-Exchange-Organization-Rules-Execution-History: 0b0cf904-14ac-4724-8bdf-482ee6223cf2%%%fd34672d-751c-45ae-a963-ed177fcabe23%%%d8080257-b0c3-47b4-b0db-23bc0c8ddb3c%%%95e591a2-5d7d-4afa-b1d0-7573d6c0a5d9%%%f7d0f6bc-4dcc-4876-8c5d-b3d6ddbb3d55%%%16355082-c50b-4214-9c7d-d39575f9f79b
X-MS-Exchange-Forest-RulesExecuted: mbx-essen-02
X-MS-Exchange-Organization-RulesExecuted: mbx-essen-02
X-MS-Exchange-Forest-IndexAgent-0: AQ0CZW4AAfUCAAAPAAADH4sIAAAAAAAEAJVSTW/aQBBdEoz5CP1Kem
kvI+WQBAJOKEkohyo95hA1aqVekb1eYIVjI3tNSPuD+jf7do2BpCIV
aGVm3755+2Zm/1S+hfTJ6Vw5nbNOly77nQv6entKt64SafKL7qKAj4
NoKib0EEdK9OvVerXdbuu/L+TL4ZBarZFU5Dp+LGciTpxQKEeosYh1
IEMlAke6s6H5DNQ8nrc5eduw9U0y9MWcvKvzbq/Le1dur9tu88+8O+
xcXHi859H52dllt6uprVZrOzc6qdlsbmtqrQ9ETqNh7qYGGVI8H/Cx
4JMkvQd4E/qSo6Mog5KJR3JI4wddk0F9cmkURT4ZunGzLrOdxOLSzB
VkrmeJ7BNqoZ8/buhBEHdjQa4XpWrFgWDfqPI0jkWogkfyhAxHFAsu
0BLIhz7dR5i3FH5e6DXc+SLhmfyCShqJ5VRFcV7J9VQ9TkUfJzzyoW
W2sD6M4ntXyShcEnWtA0+qZEX+Pl9TfJ6k3Tcc4ydRQDnNIun/M4Hj
RMUpVxmOflADn9OsjI2/RU4yGXgpXnkD7flfShrC1/J2bZsai+DE1L
gwKcNAhuKZ140+NzipV+8C4SZoeBQeKUoRHWXCR/qNcBrKQCRtuo0w
7zRxRyLBnOIoHY0xe4Qyoamr+LhedRM8jCBYPObm5gJXbcltm1kO8m
E1zPZ0axUz96XI8hWcZDP+rX0xtsN2CwVWwWI7iIsFy2bMZhWblaus
ZrH9IrN3WbHAdoAgKLOKxUpFZhV1ioUARy+eWkD22Ku9Qr3EWIm9ep
FcefH0I+I3zILPMquBgABMfLEqrIrcor6uDtqeocH8JlqZvdtlFvDs
yCS+zhBwcDUSjY23KM/WhBK2pi37FrMRgFNjB7m9EhDooGk19qHE7M
x57raikQIra32sQ2zXZA91pSvPpfyoCtpSKj+1nkpZT6XK2Fo6AK79
oFjLKACHN1OmbXROMp33RtbS/tHw4ww8yO8CuCjwL5dQZe3UBgAAAQ
7OAVJldHJpZXZlck9wZXJhdG9yLDEwLDA7UmV0cmlldmVyT3BlcmF0
b3IsMTEsMTtQb3N0RG9jUGFyc2VyT3BlcmF0b3IsMTAsMDtQb3N0RG
9jUGFyc2VyT3BlcmF0b3IsMTEsMDtQb3N0V29yZEJyZWFrZXJEaWFn
bm9zdGljT3BlcmF0b3IsMTAsMDtQb3N0V29yZEJyZWFrZXJEaWFnbm
9zdGljT3BlcmF0b3IsMTEsMDtUcmFuc3BvcnRXcml0ZXJQcm9kdWNl ciwyMCw3
X-MS-Exchange-Forest-IndexAgent: 1 978
X-MS-Exchange-Forest-EmailMessageHash: E1D60970
X-MS-Exchange-Forest-Language: en
X-MS-Exchange-Organization-Processed-By-Journaling: Journal Agent
X-MS-Exchange-Organization-Transport-Properties: DeliveryPriority=Low
X-MS-Exchange-Organization-Prioritization: 2:RC:REDACTED-af51df60fd698f80b064826f9ee192ca@...unet.com:49/10|SR
X-MS-Exchange-Organization-IncludeInSla: False:RecipientCountThresholdExceeded
On 3/27/2024 6:25 AM, Mateusz Polchlopek wrote:
...
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> index b71484c87a84..c9c4f255bc8b 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
...
> /**
> - * iavf_rx_checksum - Indicate in skb if hw indicated a good cksum
> + * iavf_rx_csum - Indicate in skb if hw indicated a good checksum
> * @vsi: the VSI we care about
> * @skb: skb currently being received and modified
> - * @rx_desc: the receive descriptor
> + * @ptype: decoded ptype information
> + * @csum_bits: decoded Rx descriptor information
> **/
> -static void iavf_rx_checksum(struct iavf_vsi *vsi,
> - struct sk_buff *skb,
> - union iavf_rx_desc *rx_desc)
> +static inline void iavf_rx_csum(struct iavf_vsi *vsi, struct sk_buff *skb,
Please don't use 'inline' in c files. More usages throughout this patch
as well.
> + struct iavf_rx_ptype_decoded *ptype,
> + struct iavf_rx_csum_decoded *csum_bits)
> {
Powered by blists - more mailing lists