netdev - Re: [PATCH net-next v4 1/3] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d8d3f54-4ae2-432e-9ac2-d3431436115e@ti.com>
Date: Mon, 1 Apr 2024 15:12:24 +0530
From: Chintan Vankar <c-vankar@...com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Dan Carpenter <dan.carpenter@...aro.org>,
        Siddharth Vadapalli
	<s-vadapalli@...com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        "Heiner
 Kallweit" <hkallweit1@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Andrew Lunn <andrew@...n.ch>, Roger Quadros <rogerq@...nel.org>,
        "Richard
 Cochran" <richardcochran@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, "Eric
 Dumazet" <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v4 1/3] net: ethernet: ti: am65-cpts: Enable PTP
 RX HW timestamp using CPTS FIFO



On 30/03/24 03:31, Jakub Kicinski wrote:
> On Wed, 27 Mar 2024 11:12:32 +0530 Chintan Vankar wrote:
>> CPTS module supports capturing timestamp for every packet it receives,
>> add a new function named "am65_cpts_find_rx_ts()" to get the timestamp
>> of received packets from CPTS FIFO.
>>
>> Add another function named "am65_cpts_rx_timestamp()" which internally
>> calls "am65_cpts_find_rx_ts()" function and timestamps the received
>> PTP packets.
> 
> Maybe i'm unusually tied today but reading this patch without reading
> the next one makes no sense. I mean, you say:
> 
>    CPTS module supports capturing timestamp for every packet it
>    receives...
> 
> How is that relevant here.

Yes, I got your point it is not relevant here, I will update commit
message in next version.

> 
> When you post v5 please make sure to include a cover letter, explaining
> the overall goal and impact of the series.
> 
>> +			list_del_init(&event->list);
>> +			list_add(&event->list, &cpts->pool);
> 
> list_move() ?

Thanks for suggestion, I will update these function calls.