netdev - Re: [PATCH net-next v4 2/3] net: ethernet: ti: am65-cpsw: Enable RX HW timestamp only for PTP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b40ba4a7-e2b0-46e6-a5b8-2dfaa6bbbabd@ti.com>
Date: Mon, 1 Apr 2024 15:14:59 +0530
From: Chintan Vankar <c-vankar@...com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Dan Carpenter <dan.carpenter@...aro.org>,
        Siddharth Vadapalli
	<s-vadapalli@...com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        "Heiner
 Kallweit" <hkallweit1@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Andrew Lunn <andrew@...n.ch>, Roger Quadros <rogerq@...nel.org>,
        "Richard
 Cochran" <richardcochran@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, "Eric
 Dumazet" <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] net: ethernet: ti: am65-cpsw: Enable RX
 HW timestamp only for PTP packets



On 30/03/24 03:29, Jakub Kicinski wrote:
> On Wed, 27 Mar 2024 11:12:33 +0530 Chintan Vankar wrote:
>> To prevent port lock up, disable TSTAMP_EN bit in CPTS_CONTROL
>> register. The workaround for timestamping received packets is to
>> utilize the CPTS Event FIFO that records timestamps corresponding to
>> certain events, with one such event being the reception of an
>> Ethernet packet with the EtherType field set to Precision Time
>> Protocol (PTP).
> 
> You mention EtherType here but the drive retains L4 support,
> which is somewhat confusing. Perhaps mention L4 / UDP ports
> here, too.

Okay. I will update message with your suggestion.