netdev - Re: [PATCH ethtool-next] netlink: fix typo in coalesce_reply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <359c5369-da09-49ba-a900-415f41911fa8@linux.alibaba.com>
Date: Tue, 2 Apr 2024 20:19:52 +0800
From: Heng Qi <hengqi@...ux.alibaba.com>
To: gaoxingwang <gaoxingwang1@...wei.com>
Cc: idosch@...dia.com, kuba@...nel.org, liaichun@...wei.com,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org, yanan@...wei.com,
 Jiri Pirko <jiri@...nulli.us>, mkubecek@...e.cz
Subject: Re: [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()



在 2024/4/2 下午8:16, gaoxingwang 写道:
> Add missing colon in coalesce_reply_cb()
>
> Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
> Signed-off-by: Gao Xingwang <gaoxingwang1@...wei.com>
> ---
>   netlink/coalesce.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c
> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
>   	show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> -	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> +	show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
>   		 tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
>   	show_cr();
>   

Reviewed-by: Heng Qi <hengqi@...ux.alibaba.com>