netdev - Re: [PATCH v3 net-next 5/6] net: phy: realtek: add rtl822x_c45_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZgwnHhUnWXC0buuT@makrotopia.org>
Date: Tue, 2 Apr 2024 16:41:18 +0100
From: Daniel Golle <daniel@...rotopia.org>
To: Eric Woudstra <ericwouds@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marek Behún <kabel@...nel.org>,
	Frank Wunderlich <frank-w@...lic-files.de>, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 5/6] net: phy: realtek: add
 rtl822x_c45_get_features() to set supported ports

On Tue, Apr 02, 2024 at 07:58:47AM +0200, Eric Woudstra wrote:
> Sets ETHTOOL_LINK_MODE_TP_BIT and ETHTOOL_LINK_MODE_MII_BIT in
> phydev->supported.

Why ETHTOOL_LINK_MODE_MII_BIT? None of those phys got MII as external
interface. Or am I getting something wrong here?

> 
> Signed-off-by: Eric Woudstra <ericwouds@...il.com>
> ---
>  drivers/net/phy/realtek.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index af5e77fd6576..b483aa3800e2 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -844,6 +844,16 @@ static int rtl822xb_read_status(struct phy_device *phydev)
>  	return 0;
>  }
>  
> +static int rtl822x_c45_get_features(struct phy_device *phydev)
> +{
> +	linkmode_set_bit(ETHTOOL_LINK_MODE_TP_BIT,
> +			 phydev->supported);
> +	linkmode_set_bit(ETHTOOL_LINK_MODE_MII_BIT,
> +			 phydev->supported);
> +
> +	return genphy_c45_pma_read_abilities(phydev);
> +}
> +
>  static int rtl822x_c45_config_aneg(struct phy_device *phydev)
>  {
>  	bool changed = false;
> @@ -1273,6 +1283,7 @@ static struct phy_driver realtek_drvs[] = {
>  		.name           = "RTL8221B-VB-CG 2.5Gbps PHY (C45)",
>  		.config_init    = rtl822xb_config_init,
>  		.get_rate_matching = rtl822xb_get_rate_matching,
> +		.get_features   = rtl822x_c45_get_features,
>  		.config_aneg    = rtl822x_c45_config_aneg,
>  		.read_status    = rtl822xb_c45_read_status,
>  		.suspend        = genphy_c45_pma_suspend,
> @@ -1294,6 +1305,7 @@ static struct phy_driver realtek_drvs[] = {
>  		.name           = "RTL8221B-VN-CG 2.5Gbps PHY (C45)",
>  		.config_init    = rtl822xb_config_init,
>  		.get_rate_matching = rtl822xb_get_rate_matching,
> +		.get_features   = rtl822x_c45_get_features,
>  		.config_aneg    = rtl822x_c45_config_aneg,
>  		.read_status    = rtl822xb_c45_read_status,
>  		.suspend        = genphy_c45_pma_suspend,
> -- 
> 2.42.1
>