netdev - Re: [PATCH v3 net-next 5/6] net: phy: realtek: add rtl822x_c45_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c493af30-053e-4f05-be81-fb701a84951a@gmail.com>
Date: Tue, 2 Apr 2024 20:31:50 +0200
From: Eric Woudstra <ericwouds@...il.com>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Marek Behún <kabel@...nel.org>,
 Frank Wunderlich <frank-w@...lic-files.de>, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 5/6] net: phy: realtek: add
 rtl822x_c45_get_features() to set supported ports

On 4/2/24 17:41, Daniel Golle wrote:
> On Tue, Apr 02, 2024 at 07:58:47AM +0200, Eric Woudstra wrote:
>> Sets ETHTOOL_LINK_MODE_TP_BIT and ETHTOOL_LINK_MODE_MII_BIT in
>> phydev->supported.
> 
> Why ETHTOOL_LINK_MODE_MII_BIT? None of those phys got MII as external
> interface. Or am I getting something wrong here?
> 

I have copied it from my rtl8153:

# ethtool enu1u1
Settings for enu1u1:
	Supported ports: [ TP	 MII ]

But I see on rtl8125 it is indeed only TP, so it looks like I chose the
wrong example. I'll remove MII then if, this should not be there.

The thing is, if no ports are set here, then from ethtool it looks like
all ports are supported.