netdev - Re: [PATCH net-next 03/15] mlxsw: pci: Do not setup tasklet from operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240403123727.GY26556@kernel.org>
Date: Wed, 3 Apr 2024 13:37:27 +0100
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 03/15] mlxsw: pci: Do not setup tasklet from
 operation

On Tue, Apr 02, 2024 at 03:54:16PM +0200, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> Currently, the structure 'mlxsw_pci_queue_ops' holds a pointer to the
> callback function of tasklet. This is used only for EQ and CQ. mlxsw
> driver will use NAPI in a following patch set, so CQ will not use tasklet
> anymore. As preparation, remove this pointer from the shared operation
> structure and setup the tasklet as part of queue initialization.
> For now, setup tasklet for EQ and CQ. Later, CQ code will be changed.
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>