netdev - Re: [PATCH net-next 04/15] mlxsw: pci: Arm CQ doorbell regardless of number of completions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240403123743.GZ26556@kernel.org>
Date: Wed, 3 Apr 2024 13:37:43 +0100
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 04/15] mlxsw: pci: Arm CQ doorbell regardless of
 number of completions

On Tue, Apr 02, 2024 at 03:54:17PM +0200, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> Currently, as part of mlxsw_pci_cq_tasklet(), we check if any item
> was handled, and only in such case we arm doorbell. This is unlikely case,
> as we schedule tasklet only for CQs that we get an event for them, which
> means that they contain completions to handle. Remove this check, which
> is supposed to be true always, and even if it is false, it is not a mistake
> to ring the doorbell. We can warn on such case, but it is not really worth
> to add a check which will be run for each CQ handling when we do not expect
> to reach it and it does not point to logic error that should be handled.
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>