netdev - Re: [PATCH net-next 05/15] mlxsw: pci: Remove unused counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240403123800.GA26556@kernel.org>
Date: Wed, 3 Apr 2024 13:38:00 +0100
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 05/15] mlxsw: pci: Remove unused counters

On Tue, Apr 02, 2024 at 03:54:18PM +0200, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> The structure 'mlxsw_pci_queue' stores several counters which were consumed
> via debugfs. Since commit 9a32562becd9 ("mlxsw: Remove debugfs interface"),
> these counters are not used. Remove them. This makes the 'union u' and
> 'struct eq' redundant. Maintain 'struct cq' as it will be extended later.
> 
> Replace increasing 'q->u.eq.ev_other_count' with WARN_ON_ONCE(), as it is
> used in an unreasonable case of receiving event in EQ which is not EQ0 or
> EQ1. When the queues are initialized, we check number of event queues and
> fail with the print "Unsupported number of queues" in case that the driver
> tries to initialize more than two queues.
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>