netdev - Re: [PATCH net-next 12/15] mlxsw: pci: Break mlxsw_pci_cq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240403124010.GH26556@kernel.org>
Date: Wed, 3 Apr 2024 13:40:10 +0100
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 12/15] mlxsw: pci: Break mlxsw_pci_cq_tasklet()
 into tasklets per queue type

On Tue, Apr 02, 2024 at 03:54:25PM +0200, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> Completion queues are used for completions of RDQ or SDQ. Each
> completion queue is used for one DQ. The first CQs are used for SDQs and
> the rest are used for RDQs.
> 
> Currently, for each CQE (completion queue element), we check 'sr' value
> (send/receive) to know if it is completion of RDQ or SDQ. Actually, we
> do not really have to check it, as according to the queue number we know
> if it handles completions of Rx or Tx.
> 
> Break the tasklet into two - one for Rx (RDQ) and one for Tx (SDQ). Then,
> setup the appropriate tasklet for each queue as part of queue
> initialization. Use 'sr' value for unlikely case that we get completion
> with type that we do not expect. Call WARN_ON_ONCE() only after checking
> the value, to avoid calling this method for each completion.
> 
> A next patch set will use NAPI to handle events, then we will have a
> separate poll method for Rx and Tx. This change is a preparation for
> NAPI usage.
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>