netdev - Re: [PATCH net-next 13/15] mlxsw: pci: Remove mlxsw_pci_sdq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240403124026.GI26556@kernel.org>
Date: Wed, 3 Apr 2024 13:40:26 +0100
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 13/15] mlxsw: pci: Remove mlxsw_pci_sdq_count()

On Tue, Apr 02, 2024 at 03:54:26PM +0200, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> The number of SDQs is stored as part of 'mlxsw_pci' structure. In some
> cases, the driver uses this value and in some cases it calls
> mlxsw_pci_sdq_count() to get the value. Align the code to use the
> stored value. This simplifies the code and makes it clearer that the
> value is always the same. Rename 'mlxsw_pci->num_sdq_cqs' to
> 'mlxsw_pci->num_sdqs' as now it is used not only in CQ context.
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>