netdev - Re: [PATCH net-next 15/15] mlxsw: pci: Store DQ pointer as part of CQ structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 3 Apr 2024 13:40:58 +0100
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 15/15] mlxsw: pci: Store DQ pointer as part of
 CQ structure

On Tue, Apr 02, 2024 at 03:54:28PM +0200, Petr Machata wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> Currently, for each completion, we check the number of descriptor queue
> and take it via mlxsw_pci_{sdq,rdq}_get(). This is inefficient, the
> DQ should be the same for all the completions in CQ, as each CQ handles
> only one DQ - SDQ or RDQ. This mapping is handled as part of DQ
> initialization via mlxsw_cmd_mbox_sw2hw_dq_cq_set().
> 
> Instead, as part of DQ initialization, set DQ pointer in the appropriate
> CQ structure. When we handle completions, warn in case that the DQ number
> that we expect is different from the number we get in the CQE. Call
> WARN_ON_ONCE() only after checking the value, to avoid calling this method
> for each completion.
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>