netdev - Re: [PATCH net v3] net: usb: ax88179_178a: avoid the interface always configured as random address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240402183012.119f1511@kernel.org>
Date: Tue, 2 Apr 2024 18:30:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
Cc: horms@...nel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, linux-usb@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org, Dave Stevenson
 <dave.stevenson@...pberrypi.com>
Subject: Re: [PATCH net v3] net: usb: ax88179_178a: avoid the interface
 always configured as random address

On Mon,  1 Apr 2024 10:19:50 +0200 Jose Ignacio Tornos Martinez wrote:
>  	if (is_valid_ether_addr(mac)) {
>  		eth_hw_addr_set(dev->net, mac);
> +		dev->net->addr_assign_type = NET_ADDR_PERM;

Are we 100% sure we won't read back the random address we wrote earlier?
Maybe let's put the assignment under if (!is_local_ether_addr(mac)),
just to be on the safe side?