netdev - Re: [PATCHv3 net-next 2/2] ynl: support binary/u32 sub-type for indexed-array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240402193551.38a5aead@kernel.org>
Date: Tue, 2 Apr 2024 19:35:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Donald
 Hunter <donald.hunter@...il.com>, Jiri Pirko <jiri@...nulli.us>, Jacob
 Keller <jacob.e.keller@...el.com>, Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCHv3 net-next 2/2] ynl: support binary/u32 sub-type for
 indexed-array

On Wed, 3 Apr 2024 10:28:34 +0800 Hangbin Liu wrote:
> I didn't check other subsystem. For bonding only, if we don't have the hint.
> e.g.
> 
>   -
>     name: arp-ip-target
>     type: indexed-array
>     sub-type: u32
> 
> The result will looks like:
> 
>     "arp-ip-target": [
>       "c0a80101",
>       "c0a80102"
>     ],
> 
> Which looks good to me. Do you have other suggestion?

That doesn't look right, without the format hint if the type is u32 
the members should be plain integers not hex strings.