netdev - Re: [PATCHv3 net-next 2/2] ynl: support binary/u32 sub-type for indexed-array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZgzMmqWzRvdk4wzP@Laptop-X1>
Date: Wed, 3 Apr 2024 11:27:22 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Donald Hunter <donald.hunter@...il.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCHv3 net-next 2/2] ynl: support binary/u32 sub-type for
 indexed-array

On Tue, Apr 02, 2024 at 07:35:51PM -0700, Jakub Kicinski wrote:
> On Wed, 3 Apr 2024 10:28:34 +0800 Hangbin Liu wrote:
> > I didn't check other subsystem. For bonding only, if we don't have the hint.
> > e.g.
> > 
> >   -
> >     name: arp-ip-target
> >     type: indexed-array
> >     sub-type: u32
> > 
> > The result will looks like:
> > 
> >     "arp-ip-target": [
> >       "c0a80101",
> >       "c0a80102"
> >     ],
> > 
> > Which looks good to me. Do you have other suggestion?
> 
> That doesn't look right, without the format hint if the type is u32 
> the members should be plain integers not hex strings.

OK, I can separate the binary and u32 dealing. How about like

diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py
index e5ad415905c7..be42e4fc1037 100644
--- a/tools/net/ynl/lib/ynl.py
+++ b/tools/net/ynl/lib/ynl.py
@@ -640,6 +640,16 @@ class YnlFamily(SpecFamily):
             if attr_spec["sub-type"] == 'nest':
                 subattrs = self._decode(NlAttrs(item.raw), attr_spec['nested-attributes'])
                 decoded.append({ item.type: subattrs })
+            elif attr_spec["sub-type"] == 'binary':
+                subattrs = item.as_bin()
+                if attr_spec.display_hint:
+                    subattrs = self._formatted_string(subattrs, attr_spec.display_hint)
+                decoded.append(subattrs)
+            elif attr_spec["sub-type"] in NlAttr.type_formats:
+                subattrs = item.as_scalar(attr_spec['sub-type'], attr_spec.byte_order)
+                if attr_spec.display_hint:
+                    subattrs = self._formatted_string(subattrs, attr_spec.display_hint)
+                decoded.append(subattrs)
             else:
                 raise Exception(f'Unknown {attr_spec["sub-type"]} with name {attr_spec["name"]}')
         return decoded


With only sub-type: u32 it shows like

    "arp-ip-target": [
      3232235777,
      3232235778
    ],

Thanks
Hangbin