netdev - Re: [PATCH bpf-next 2/2] selftests/bpf: Add testcase where 7th argment is struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0626619d-5950-497e-aa67-a13cede9b300@huaweicloud.com>
Date: Wed, 3 Apr 2024 11:24:34 +0800
From: Pu Lehui <pulehui@...weicloud.com>
To: Daniel Borkmann <daniel@...earbox.net>, bpf@...r.kernel.org,
 linux-riscv@...ts.infradead.org, netdev@...r.kernel.org
Cc: Björn Töpel <bjorn@...nel.org>,
 Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman
 <eddyz87@...il.com>, Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
 Pu Lehui <pulehui@...wei.com>
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Add testcase where 7th
 argment is struct


On 2024/4/2 22:02, Daniel Borkmann wrote:
> On 3/31/24 11:24 AM, Pu Lehui wrote:
>> From: Pu Lehui <pulehui@...wei.com>
>>
>> Add testcase where 7th argument is struct for architectures with 8
>> argument registers, and increase the complexity of the struct.
>>
>> Signed-off-by: Pu Lehui <pulehui@...wei.com>
>> ---
>>   .../selftests/bpf/bpf_testmod/bpf_testmod.c   | 19 ++++++++++
>>   .../selftests/bpf/prog_tests/tracing_struct.c | 13 +++++++
>>   .../selftests/bpf/progs/tracing_struct.c      | 35 +++++++++++++++++++
>>   3 files changed, 67 insertions(+)
> 
> The last test from this patch fails BPF CI, ptal :
> 
> https://github.com/kernel-patches/bpf/actions/runs/8497262674/job/23275690303
> https://github.com/kernel-patches/bpf/actions/runs/8497262674/job/23275690364
> 
> Notice: Success: 519/3592, Skipped: 53, Failed: 1
> Error: #391 tracing_struct
>    Error: #391 tracing_struct
>    test_fentry:PASS:tracing_struct__open_and_load 0 nsec
>    libbpf: prog 'test_struct_arg_16': failed to attach: ERROR: 
> strerror_r(-524)=22
>    libbpf: prog 'test_struct_arg_16': failed to auto-attach: -524
>    test_fentry:FAIL:tracing_struct__attach unexpected error: -524 (errno 
> 524)
> Test Results:
>               bpftool: PASS
>            test_progs: FAIL (returned 1)
> Error: Process completed with exit code 1.

Thanks for your reminder. aarch64 does not yet support bpf trampoline 
with more than 8 parameters. I will add tracing_struct to DENYLIST.aarch64.