netdev - Re: [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across suspends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ebf88d8f-c5e7-49c1-ac7f-ee7fef9bffe3@leica-geosystems.com>
Date: Wed, 3 Apr 2024 07:15:07 +0000
From: POPESCU Catalin <catalin.popescu@...ca-geosystems.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>, "hkallweit1@...il.com"
	<hkallweit1@...il.com>, "linux@...linux.org.uk" <linux@...linux.org.uk>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"m.felsch@...gutronix.de" <m.felsch@...gutronix.de>,
	GEO-CHHER-bsp-development <bsp-development.geo@...ca-geosystems.com>
Subject: Re: [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across
 suspends

On 03/04/2024 02:45, Jakub Kicinski wrote:
> [Some people who received this message don't often get email from kuba@...nel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On Thu, 28 Mar 2024 14:33:58 +0100 Catalin Popescu wrote:
>> -static int dp83822_set_wol(struct phy_device *phydev,
>> -                        struct ethtool_wolinfo *wol)
>> +static int _dp83822_set_wol(struct phy_device *phydev,
>> +                         struct ethtool_wolinfo *wol)
> Why the underscore, you can all this any number of things maybe
> dp83822_config_wol() or dp83822_apply_wol()?

Sure, I'll use dp83822_config_wol.