netdev - Re: [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across suspends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240402174536.75cbe074@kernel.org>
Date: Tue, 2 Apr 2024 17:45:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 m.felsch@...gutronix.de, bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across
 suspends

On Thu, 28 Mar 2024 14:33:58 +0100 Catalin Popescu wrote:
> -static int dp83822_set_wol(struct phy_device *phydev,
> -			   struct ethtool_wolinfo *wol)
> +static int _dp83822_set_wol(struct phy_device *phydev,
> +			    struct ethtool_wolinfo *wol)

Why the underscore, you can all this any number of things maybe
dp83822_config_wol() or dp83822_apply_wol()?