netdev - Re: [PATCH net-next 3/5] ethtool: add interface to read representor Rx statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ttkf2h71.fsf@nvidia.com>
Date: Fri, 05 Apr 2024 22:25:21 -0700
From: Rahul Rameshbabu <rrameshbabu@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Tariq Toukan <tariqt@...dia.com>, Carolina Jubran <cjubran@...dia.com>,
 Simon Horman <horms@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 netdev@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>, Gal Pressman
 <gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH net-next 3/5] ethtool: add interface to read representor
 Rx statistics

On Fri, 05 Apr, 2024 21:53:35 -0700 Jakub Kicinski <kuba@...nel.org> wrote:
> On Thu, 4 Apr 2024 20:33:55 +0300 Tariq Toukan wrote:
>> +/**
>> + * struct ethtool_rep_port_stats - representor port statistics
>> + * @rep_port_stats: struct group for representor port
>
> In more trivial remarks - kernel-doc script apparently doesn't want
> the group to be documented (any more?)
>

I took a look, and I believe the behavior of kernel-doc has remained the
same since the struct_group() helper macro was introduced. That said, I
think allowing the documentation of struct_group() would be a reasonable
choice/maybe worth updating the script.

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=50d7bd38c3aafc4749e05e8d7fcb616979143602

>> + *	@out_of_buf: Number of packets were dropped due to buffer exhaustion.
>> + */
>> +struct ethtool_rep_port_stats {
>> +	struct_group(rep_port_stats,
>> +		u64 out_of_buf;
>> +	);
>> +};
>> +