netdev - Re: [PATCH iwl-next v5] ice: Add automatic VF reset on Tx MDD events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240408133217.GI26556@kernel.org>
Date: Mon, 8 Apr 2024 14:32:17 +0100
From: Simon Horman <horms@...nel.org>
To: Marcin Szycik <marcin.szycik@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	mschmidt@...hat.com, anthony.l.nguyen@...el.com,
	pawel.chmielewski@...el.com, aleksandr.loktionov@...el.com,
	Wojciech Drewek <wojciech.drewek@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Liang-Min Wang <liang-min.wang@...el.com>
Subject: Re: [PATCH iwl-next v5] ice: Add automatic VF reset on Tx MDD events

On Thu, Apr 04, 2024 at 04:04:51PM +0200, Marcin Szycik wrote:
> In cases when VF sends malformed packets that are classified as malicious,
> it can cause Tx queue to freeze as a result of Malicious Driver Detection
> event. Such malformed packets can appear as a result of a faulty userspace
> app running on VF. This frozen queue can be stuck for several minutes being
> unusable.
> 
> User might prefer to immediately bring the VF back to operational state
> after such event, which can be done by automatically resetting the VF which
> caused MDD. This is already implemented for Rx events (mdd-auto-reset-vf
> flag private flag needs to be set).
> 
> Extend the VF auto reset to also cover Tx MDD events. When any MDD event
> occurs on VF (Tx or Rx) and the mdd-auto-reset-vf private flag is set,
> perform a graceful VF reset to quickly bring it back to operational state.
> 
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Co-developed-by: Liang-Min Wang <liang-min.wang@...el.com>
> Signed-off-by: Liang-Min Wang <liang-min.wang@...el.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@...ux.intel.com>

Reviewed-by: Simon Horman <horms@...nel.org>