netdev - RE: [Intel-wired-lan] [PATCH iwl-next v5] ice: Add automatic VF reset on Tx MDD events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58650E908FAE86CBDDBA5DFC8F082@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Tue, 16 Apr 2024 15:06:34 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Simon Horman <horms@...nel.org>, Marcin Szycik
	<marcin.szycik@...ux.intel.com>
CC: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, "Drewek, Wojciech"
	<wojciech.drewek@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Chmielewski, Pawel" <pawel.chmielewski@...el.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Wang, Liang-min"
	<liang-min.wang@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v5] ice: Add automatic VF reset
 on Tx MDD events

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Simon
> Horman
> Sent: Monday, April 8, 2024 3:32 PM
> To: Marcin Szycik <marcin.szycik@...ux.intel.com>
> Cc: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Drewek, Wojciech
> <wojciech.drewek@...el.com>; netdev@...r.kernel.org; Chmielewski, Pawel
> <pawel.chmielewski@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Wang, Liang-min <liang-min.wang@...el.com>;
> Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; intel-wired-
> lan@...ts.osuosl.org
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5] ice: Add automatic VF reset on
> Tx MDD events
> 
> On Thu, Apr 04, 2024 at 04:04:51PM +0200, Marcin Szycik wrote:
> > In cases when VF sends malformed packets that are classified as
> > malicious, it can cause Tx queue to freeze as a result of Malicious
> > Driver Detection event. Such malformed packets can appear as a result
> > of a faulty userspace app running on VF. This frozen queue can be
> > stuck for several minutes being unusable.
> >
> > User might prefer to immediately bring the VF back to operational
> > state after such event, which can be done by automatically resetting
> > the VF which caused MDD. This is already implemented for Rx events
> > (mdd-auto-reset-vf flag private flag needs to be set).
> >
> > Extend the VF auto reset to also cover Tx MDD events. When any MDD
> > event occurs on VF (Tx or Rx) and the mdd-auto-reset-vf private flag
> > is set, perform a graceful VF reset to quickly bring it back to operational state.
> >
> > Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> > Co-developed-by: Liang-Min Wang <liang-min.wang@...el.com>
> > Signed-off-by: Liang-Min Wang <liang-min.wang@...el.com>
> > Signed-off-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> 
> Reviewed-by: Simon Horman <horms@...nel.org>


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>