netdev - Re: [PATCH net] bonding: 802.3ad: Avoid packet loss when switching aggregator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240409163423.7d0b8fe9@samweis>
Date: Tue, 9 Apr 2024 16:34:23 +0200
From: Thomas Bogendoerfer <tbogendoerfer@...e.de>
To: Simon Horman <horms@...nel.org>
Cc: Jay Vosburgh <j.vosburgh@...il.com>, Andy Gospodarek
 <andy@...yhouse.net>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] bonding: 802.3ad: Avoid packet loss when switching
 aggregator

On Sat, 6 Apr 2024 17:03:54 +0100
Simon Horman <horms@...nel.org> wrote:

> On Thu, Apr 04, 2024 at 01:49:08PM +0200, Thomas Bogendoerfer wrote:
> > If selection logic decides to switch to a new aggregator it disables
> > all ports of the old aggregator, but doesn't enable ports on
> > the new aggregator. These ports will eventually be enabled when
> > the next LACPDU is received, which might take some time and without an
> > active port transmitted frames are dropped. Avoid this by enabling
> > already collected ports of the new aggregator immediately.
> > 
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>  
> 
> Hi Thomas,
> 
> I will leave the technical review to Jay and others.  But as a fix, I think
> this patch warrants a Fixes tag. It should be sufficient to respond to this
> email thread with an appropriate tag.

current behavior is older than our git tree. So should I really add

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

?

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Ivo Totev, Andrew McDonald, Werner Knoblich