netdev - Re: [PATCH net-next] selftests: fib_rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63122565-b5a3-48d6-829e-2e2a3d5a1021@gmail.com>
Date: Tue, 9 Apr 2024 08:40:40 -0600
From: David Ahern <dsahern@...il.com>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, liuhangbin@...il.com, gnault@...hat.com,
 ssuryaextr@...il.com
Subject: Re: [PATCH net-next] selftests: fib_rule_tests: Add VRF tests

On 4/9/24 5:08 AM, Ido Schimmel wrote:
> After commit 40867d74c374 ("net: Add l3mdev index to flow struct and
> avoid oif reset for port devices") it is possible to configure FIB rules
> that match on iif / oif being a l3mdev port. It was not possible before
> as these parameters were reset to the ifindex of the l3mdev device
> itself prior to the FIB rules lookup.
> 
> Add tests that cover this functionality as it does not seem to be
> covered by existing ones and I am aware of at least one user that needs
> this functionality in addition to the one mentioned in [1].
> 
> Reuse the existing FIB rules tests by simply configuring a VRF prior to
> the test and removing it afterwards. Differentiate the output of the
> non-VRF tests from the VRF tests by appending "(VRF)" to the test name
> if a l3mdev FIB rule is present.
> 
> Verified that these tests do fail on kernel 5.15.y which does not
> include the previously mentioned commit:
> 
>  # ./fib_rule_tests.sh -t fib_rule6_vrf
>  [...]
>      TEST: rule6 check: oif redirect to table (VRF)                      [FAIL]
>  [...]
>      TEST: rule6 check: iif redirect to table (VRF)                      [FAIL]
> 
>  # ./fib_rule_tests.sh -t fib_rule4_vrf
>  [...]
>      TEST: rule4 check: oif redirect to table (VRF)                      [FAIL]
>  [...]
>      TEST: rule4 check: iif redirect to table (VRF)                      [FAIL]
> 
> [1] https://lore.kernel.org/netdev/20200922131122.GB1601@ICIPI.localdomain/
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  tools/testing/selftests/net/fib_rule_tests.sh | 46 +++++++++++++++++--
>  1 file changed, 43 insertions(+), 3 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>

Thanks, Ido.