netdev - Re: [PATCH net-next 3/3] bonding: no longer use RTNL in bonding_show_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18657.1712696014@famine>
Date: Tue, 09 Apr 2024 13:53:34 -0700
From: Jay Vosburgh <jay.vosburgh@...onical.com>
To: Eric Dumazet <edumazet@...gle.com>
cc: "David S . Miller" <davem@...emloft.net>,
    Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
    Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org,
    eric.dumazet@...il.com
Subject: Re: [PATCH net-next 3/3] bonding: no longer use RTNL in bonding_show_queue_id()

Eric Dumazet <edumazet@...gle.com> wrote:

>On Tue, Apr 9, 2024 at 10:39 PM Jay Vosburgh <jay.vosburgh@...onical.com> wrote:
>>
>> Eric Dumazet <edumazet@...gle.com> wrote:
>>
>> >Annotate lockless reads of slave->queue_id.
>> >
>> >Annotate writes of slave->queue_id.
>> >
>> >Switch bonding_show_queue_id() to rcu_read_lock()
>> >and bond_for_each_slave_rcu().
>>
>>         This is combining two logical changes into one patch, isn't it?
>> The annotation change isn't part of what's stated in the Subject.
>
>The annotations are really part of this change, otherwise KCSAN might
>find races.

	Works for me.

Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>

	-J

---
	-Jay Vosburgh, jay.vosburgh@...onical.com