netdev - Re: [PATCH] iplink: add an option to set IFLA_EXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 8 Apr 2024 17:29:55 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: renmingshuai <renmingshuai@...wei.com>
Cc: <dsahern@...il.com>, <liaichun@...wei.com>, <netdev@...r.kernel.org>,
 <yanan@...wei.com>
Subject: Re: [PATCH] iplink: add an option to set IFLA_EXT_MASK attribute

On Mon, 8 Apr 2024 20:34:58 +0800
renmingshuai <renmingshuai@...wei.com> wrote:

> >> Kernel has add IFLA_EXT_MASK attribute for indicating that certain
> >> extended ifinfo values are requested by the user application. The ip
> >> link show cmd always request VFs extended ifinfo.
> >> 
> >> RTM_GETLINK for greater than about 220 VFs truncates IFLA_VFINFO_LIST
> >> due to the maximum reach of nlattr's nla_len being exceeded.
> >> As a result, ip link show command only show the truncated VFs info
> >> sucn as:
> >> 
> >>     #ip link show dev eth0
> >>     1: eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 ...
> >>         link/ether ...
> >>         vf 0     link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
> >>         ...
> >>     Truncated VF list: eth0
> >> 
> >> Add an option to set IFLA_EXT_MASK attribute and users can choose to
> >> show the extended ifinfo or not.
> >> 
> >> Signed-off-by: Mingshuai Ren <renmingshuai@...wei.com>  
> >
> > Adding a new option with on/off seems like more than is necessary.
> > If we need an option it should just be one word. Any new filter should
> > have same conventions as existing filters.  Maybe 'novf'
> > 
> > And it looks like not sending IFLA_EXT_MASK will break the changes
> > made for the link filter already done for VF's.  
> 
> Thanks for your reply. As you suggested, I've added an option
> named noVF, which has same conventions as existing filter.
> Also, this new patch does not send RTEXT_FILTER_VF instead of
> IFLA_EXT_MASK, and it does not break the changes made for the link
> filter already done for VF's.
> Please review it again.

Did you read my comment. Any new option should look the same as all
the other options in the command.  Is there any option to ip commands
that uses mixed case? No. Please stick to lower case.