netdev - Re: [PATCH net-next] tcp: tweak tcp_sock_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240410144959.i6forc4wqufwfqpr@skbuf>
Date: Wed, 10 Apr 2024 17:49:59 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next] tcp: tweak tcp_sock_write_txrx size assertion

On Tue, Apr 09, 2024 at 02:09:14PM +0000, Eric Dumazet wrote:
> I forgot 32bit arches might have 64bit alignment for u64
> fields.
> 
> tcp_sock_write_txrx group does not contain pointers,
> but two u64 fields. It is possible that on 32bit kernel,
> a 32bit hole is before tp->tcp_clock_cache.
> 
> I will try to remember a group can be bigger on 32bit
> kernels in the future.
> 
> With help from Vladimir Oltean.
> 
> Fixes: d2c3a7eb1afa ("tcp: more struct tcp_sock adjustments")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404082207.HCEdQhUO-lkp@intel.com/
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Vladimir Oltean <vladimir.oltean@....com>
> ---

Tested-by: Vladimir Oltean <vladimir.oltean@....com>