netdev - Re: [PATCH] ip: Support filter links with no VF info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bc56a4f-ff48-43c8-87b3-8d5d23a30997@gmail.com>
Date: Wed, 10 Apr 2024 08:47:34 -0600
From: David Ahern <dsahern@...il.com>
To: renmingshuai <renmingshuai@...wei.com>, netdev@...r.kernel.org,
 stephen@...workplumber.org
Cc: yanan@...wei.com, liaichun@...wei.com
Subject: Re: [PATCH] ip: Support filter links with no VF info

On 4/9/24 8:51 PM, renmingshuai wrote:
> @@ -2139,6 +2141,7 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
>  	ipaddr_reset_filter(oneline, 0);
>  	filter.showqueue = 1;
>  	filter.family = preferred_family;
> +	filter.vfinfo = 0;
>  
>  	if (action == IPADD_FLUSH) {
>  		if (argc <= 0) {
> @@ -2221,6 +2224,8 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
>  				invarg("\"proto\" value is invalid\n", *argv);
>  			filter.have_proto = true;
>  			filter.proto = proto;
> +		} else if (strcmp(*argv, "novf") == 0) {
> +			filter.vfinfo = -1;
>  		} else {
>  			if (strcmp(*argv, "dev") == 0)
>  				NEXT_ARG();

The reverse logic is how other filters work. Meaning vfinfo is set, add
the RTEXT_FILTER_VF flag (default for backwards compatibility). From
there, "novf" set vfinfo to 0 and flag is not added.