netdev - Re: [PATCH] ip: Support filter links with no VF info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240411025756.59008-1-renmingshuai@huawei.com>
Date: Thu, 11 Apr 2024 10:57:56 +0800
From: renmingshuai <renmingshuai@...wei.com>
To: <dsahern@...il.com>
CC: <liaichun@...wei.com>, <netdev@...r.kernel.org>,
	<renmingshuai@...wei.com>, <stephen@...workplumber.org>, <yanan@...wei.com>
Subject: Re: [PATCH] ip: Support filter links with no VF info

> > @@ -2139,6 +2141,7 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
> >  	ipaddr_reset_filter(oneline, 0);
> >  	filter.showqueue = 1;
> >  	filter.family = preferred_family;
> > +	filter.vfinfo = 0;
> >  
> >  	if (action == IPADD_FLUSH) {
> >  		if (argc <= 0) {
> > @@ -2221,6 +2224,8 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
> >  				invarg("\"proto\" value is invalid\n", *argv);
> >  			filter.have_proto = true;
> >  			filter.proto = proto;
> > +		} else if (strcmp(*argv, "novf") == 0) {
> > +			filter.vfinfo = -1;
> >  		} else {
> >  			if (strcmp(*argv, "dev") == 0)
> >  				NEXT_ARG();
> 
> The reverse logic is how other filters work. Meaning vfinfo is set, add
> the RTEXT_FILTER_VF flag (default for backwards compatibility). From
> there, "novf" set vfinfo to 0 and flag is not added.

As you suggested, I've modified it and submitted a new patch.