netdev - Re: [PATCH net-next v4 1/9] net: free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240409184625.301e4bc0@kernel.org>
Date: Tue, 9 Apr 2024 18:46:25 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: aleksander.lobakin@...el.com, davem@...emloft.net, pabeni@...hat.com,
 edumazet@...gle.com, elder@...nel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 nbd@....name, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
 lorenzo@...nel.org, taras.chornyi@...ision.eu, ath11k@...ts.infradead.org,
 ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
 geomatsi@...il.com, kvalo@...nel.org, quic_jjohnson@...cinc.com,
 leon@...nel.org, dennis.dalessandro@...nelisnetworks.com,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org, bpf@...r.kernel.org,
 Jiri Pirko <jiri@...nulli.us>, Simon Horman <horms@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Sebastian Andrzej Siewior
 <bigeasy@...utronix.de>
Subject: Re: [PATCH net-next v4 1/9] net: free_netdev: exit earlier if dummy

On Tue,  9 Apr 2024 05:57:15 -0700 Breno Leitao wrote:
> For dummy devices, exit earlier at free_netdev() instead of executing
> the whole function. This is necessary, because dummy devices are
> special, and shouldn't have the second part of the function executed.
> 
> Otherwise reg_state, which is NETREG_DUMMY for dummy devices, will be
> overwritten and there will be no way to identify that this is a dummy
> device. Also, this device do not need the final put_device(), since
> dummy devices are not registered (through register_netdevice()), where
> the device reference is increased (at netdev_register_kobject() ->
> device_add()).

There's a small fuzz when applying due to the phy topo changes
landing, please rebase, the CI didn't ingest it right.
-- 
pw-bot: cr