netdev - Re: [PATCH net-next v10 2/6] net: stmmac: Add multi-channel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0524fb13-6698-47d2-830e-277398f440cd@loongson.cn>
Date: Wed, 10 Apr 2024 09:48:38 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Simon Horman <horms@...nel.org>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, fancer.lancer@...il.com,
 Jose.Abreu@...opsys.com, chenhuacai@...nel.org, linux@...linux.org.uk,
 guyinggang@...ngson.cn, netdev@...r.kernel.org, chris.chenfeiyang@...il.com,
 siyanteng01@...il.com
Subject: Re: [PATCH net-next v10 2/6] net: stmmac: Add multi-channel support


在 2024/4/10 02:55, Simon Horman 写道:
> On Tue, Apr 09, 2024 at 10:00:02PM +0800, Yanteng Si wrote:
>> DW GMAC v3.x multi-channels feature is implemented as multiple
>> sets of the same CSRs. Here is only preliminary support, it will
>> be useful for the driver further evolution and for the users
>> having multi-channel DWGMAC v3.x devices.
>>
>> Signed-off-by: Feiyang Chen <chenfeiyang@...ngson.cn>
>> Signed-off-by: Yinggang Gu <guyinggang@...ngson.cn>
>> Signed-off-by: Yanteng Si <siyanteng@...ngson.cn>
> ...
>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
>> index e1537a57815f..e94faa72f30e 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
>> @@ -420,6 +420,12 @@ stmmac_ethtool_set_link_ksettings(struct net_device *dev,
>>   		return 0;
>>   	}
>>   
>> +	if (priv->plat->flags & STMMAC_FLAG_DISABLE_FORCE_1000) {
> Hi Yanteng Si, Yanteng Si, all,
>
> STMMAC_FLAG_DISABLE_FORCE_1000 is used here but it is not defined
> until PATCH 6/6. This breaks bisection.
>
> I expect this can be resolved by defining STMMAC_FLAG_DISABLE_FORCE_1000
> as part of this patch.

Sorry, this is to fix some LS2K2000 and some LS7A2000 bugs, in v11 I 
will split

them to 6/6.


Thank you for your review.


Thanks,

Yanteng

>
>