netdev - Re: [net-next PATCH 04/15] eth: fbnic: Add register init to set PCIe/Ethernet device config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <434a23f1-5e82-4533-9759-12b776850ae2@intel.com>
Date: Wed, 10 Apr 2024 13:31:32 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Andrew Lunn <andrew@...n.ch>, Alexander Duyck <alexander.duyck@...il.com>
CC: <netdev@...r.kernel.org>, Alexander Duyck <alexanderduyck@...com>,
	<kuba@...nel.org>, <davem@...emloft.net>, <pabeni@...hat.com>
Subject: Re: [net-next PATCH 04/15] eth: fbnic: Add register init to set
 PCIe/Ethernet device config



On 4/3/2024 1:46 PM, Andrew Lunn wrote:
>> +#define wr32(reg, val)	fbnic_wr32(fbd, reg, val)
>> +#define rd32(reg)	fbnic_rd32(fbd, reg)
>> +#define wrfl()		fbnic_rd32(fbd, FBNIC_MASTER_SPARE_0)
> 
> I don't think that is considered best practices, using variables not
> passed to the macro.
> 
> 	Andrew
> 

Yea, please avoid this, it will only cause pain later when debugging why
something doesn't work.