netdev - Re: [net-next PATCH 00/15] eth: fbnic: Add network driver for Meta Platforms Host Network Interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06e02e6e-71a1-4966-8fd2-0151e358e465@intel.com>
Date: Wed, 10 Apr 2024 17:31:50 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Jiri Pirko <jiri@...nulli.us>, Willem de Bruijn
	<willemdebruijn.kernel@...il.com>, Jakub Kicinski <kuba@...nel.org>,
	<pabeni@...hat.com>, John Fastabend <john.fastabend@...il.com>, "Alexander
 Lobakin" <aleksander.lobakin@...el.com>, Florian Fainelli
	<f.fainelli@...il.com>, Daniel Borkmann <daniel@...earbox.net>, Edward Cree
	<ecree.xilinx@...il.com>, Alexander Duyck <alexander.duyck@...il.com>,
	<netdev@...r.kernel.org>, <bhelgaas@...gle.com>, <linux-pci@...r.kernel.org>,
	Alexander Duyck <alexanderduyck@...com>
Subject: Re: [net-next PATCH 00/15] eth: fbnic: Add network driver for Meta
 Platforms Host Network Interface



On 4/10/2024 3:19 PM, Andrew Lunn wrote:
>> I think its good practice to ensure multiple vendors/drivers can use
>> whatever common uAPI or kernel API exists. It can be frustrating when
>> some new API gets introduced but then can't be used by another device..
>> In most cases thats on the vendors for being slow to respond or work
>> with each other when developing the new API.
> 
> I tend to agree with the last part. Vendors tend not to reviewer other
> vendors patches, and so often don't notice a new API being added which
> they could use, if it was a little bit more generic. Also vendors
> often seem to focus on their devices/firmware requirements, not an
> abstract device, and so end up with something not generic.
> 
> As a reviewer, i try to take more notice of new APIs than most other
> things, and ideally it is something we should all do.
> 
> 	 Andrew
> 
> 
> 

Agreed. It can be challenging when you're in the vendor space though, as
you get handed priorities.