netdev - Re: [PATCH][next] net/handshake: remove redundant assignment to variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoBO2SPNYE+oRSkqk+YWRK0OiG5xj3uNZ448-AWMsG1A0g@mail.gmail.com>
Date: Mon, 15 Apr 2024 20:01:09 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Chuck Lever <chuck.lever@...cle.com>, "David S . Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	kernel-tls-handshake@...ts.linux.dev, netdev@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net/handshake: remove redundant assignment to
 variable ret

On Mon, Apr 15, 2024 at 6:08 PM Colin Ian King <colin.i.king@...il.com> wrote:
>
> The variable is being assigned an value and then is being re-assigned
> a new value in the next statement. The assignment is redundant and can
> be removed.
>
> Cleans up clang scan build warning:
> net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never
> read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Jason Xing <kerneljasonxing@...il.com>