netdev - Re: [PATCH][next] net/handshake: remove redundant assignment to variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zh0r8FXN45ThNLwk@tissot.1015granger.net>
Date: Mon, 15 Apr 2024 09:30:24 -0400
From: Chuck Lever <chuck.lever@...cle.com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        kernel-tls-handshake@...ts.linux.dev, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net/handshake: remove redundant assignment to
 variable ret

On Mon, Apr 15, 2024 at 11:07:13AM +0100, Colin Ian King wrote:
> The variable is being assigned an value and then is being re-assigned
> a new value in the next statement. The assignment is redundant and can
> be removed.
> 
> Cleans up clang scan build warning:
> net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never
> read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  net/handshake/tlshd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/handshake/tlshd.c b/net/handshake/tlshd.c
> index d697f68c598c..d6f52839827e 100644
> --- a/net/handshake/tlshd.c
> +++ b/net/handshake/tlshd.c
> @@ -213,7 +213,6 @@ static int tls_handshake_accept(struct handshake_req *req,
>  	if (!hdr)
>  		goto out_cancel;
>  
> -	ret = -EMSGSIZE;
>  	ret = nla_put_s32(msg, HANDSHAKE_A_ACCEPT_SOCKFD, fd);
>  	if (ret < 0)
>  		goto out_cancel;
> -- 
> 2.39.2
> 
> 

Acked-by: Chuck Lever <chuck.lever@...cle.com>

-- 
Chuck Lever