netdev - Re: [PATCH net-next v4 3/6] rstreason: prepare for active reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d3ea199eef53cf6a0c48e21abdee0eefbdee927.camel@redhat.com>
Date: Tue, 16 Apr 2024 10:01:27 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jason Xing <kerneljasonxing@...il.com>, edumazet@...gle.com, 
 dsahern@...nel.org, matttbe@...nel.org, martineau@...nel.org,
 geliang@...nel.org,  kuba@...nel.org, davem@...emloft.net,
 rostedt@...dmis.org, mhiramat@...nel.org,  mathieu.desnoyers@...icios.com,
 atenart@...nel.org
Cc: mptcp@...ts.linux.dev, netdev@...r.kernel.org, Jason Xing
	 <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v4 3/6] rstreason: prepare for active reset

On Thu, 2024-04-11 at 19:56 +0800, Jason Xing wrote:
> diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
> index 744c87b6d5a4..ba0a252c113f 100644
> --- a/net/mptcp/subflow.c
> +++ b/net/mptcp/subflow.c
> @@ -412,7 +412,7 @@ void mptcp_subflow_reset(struct sock *ssk)
>  	/* must hold: tcp_done() could drop last reference on parent */
>  	sock_hold(sk);
>  
> -	tcp_send_active_reset(ssk, GFP_ATOMIC);
> +	tcp_send_active_reset(ssk, GFP_ATOMIC, SK_RST_REASON_NOT_SPECIFIED);

I'm sorry for the late feedback.

Some of the caller can set subflow->reset_reason, so probably something
alike the following:

	tcp_send_active_reset(ssk, GFP_ATOMIC,
			      subflow->reset_reason?: SK_RST_REASON_NOT_SPECIFIED);


would work - with an helper even better.

Could be a follow-up patch.

Thanks,

Paolo