netdev - Re: [PATCH net-next v4 5/6] mptcp: support rstreason for passive reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b53762fbdfb7df1b3e79ea5138fabb714449d28.camel@redhat.com>
Date: Tue, 16 Apr 2024 10:04:30 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jason Xing <kerneljasonxing@...il.com>, edumazet@...gle.com, 
 dsahern@...nel.org, matttbe@...nel.org, martineau@...nel.org,
 geliang@...nel.org,  kuba@...nel.org, davem@...emloft.net,
 rostedt@...dmis.org, mhiramat@...nel.org,  mathieu.desnoyers@...icios.com,
 atenart@...nel.org
Cc: mptcp@...ts.linux.dev, netdev@...r.kernel.org, Jason Xing
	 <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v4 5/6] mptcp: support rstreason for passive
 reset

On Thu, 2024-04-11 at 19:56 +0800, Jason Xing wrote:
> diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
> index ba0a252c113f..25eaad94cb79 100644
> --- a/net/mptcp/subflow.c
> +++ b/net/mptcp/subflow.c
> @@ -308,8 +308,12 @@ static struct dst_entry *subflow_v4_route_req(const struct sock *sk,
>  		return dst;
>  
>  	dst_release(dst);
> -	if (!req->syncookie)
> -		tcp_request_sock_ops.send_reset(sk, skb, SK_RST_REASON_NOT_SPECIFIED);
> +	if (!req->syncookie) {
> +		struct mptcp_ext *mpext = mptcp_get_ext(skb);
> +		enum sk_rst_reason reason = convert_mptcp_reason(mpext->reset_reason);

Since you already have to repost, very minor nit: even the above
strictly speaking does not respect the reverse xmass tree.

		enum sk_rst_reason reason;

		reason = convert_mptcp_reason(mpext->reset_reason);
> +		tcp_request_sock_ops.send_reset(sk, skb, reason);

Cheers,

Paolo