netdev - Re: [PATCH net-next v2 0/4] net: sparx5: flower: validate control flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240424133905.iex24gviwgoe7h3t@DEN-DL-M70577>
Date: Wed, 24 Apr 2024 13:39:05 +0000
From: Daniel Machon <daniel.machon@...rochip.com>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>
CC: <netdev@...r.kernel.org>, Steen Hegelund <Steen.Hegelund@...rochip.com>,
	Lars Povlsen <lars.povlsen@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<linux-kernel@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>, Simon Horman
	<horms@...nel.org>
Subject: Re: [PATCH net-next v2 0/4] net: sparx5: flower: validate control
 flags

> This series adds flower control flags validation to the
> sparx5 driver, and changes it from assuming that it handles
> all control flags, to instead reject rules if they have
> masked any unknown/unsupported control flags.
> 
> ---
> 
> Changelog:
> 
> v2:
> * Split first patch into 3 (requested by Jiri)
> * Convert a missed extack usage (noticed by Daniel)
> * Added cover letter (requested by Simon and Daniel)
> 
> v1: https://lore.kernel.org/netdev/20240423102728.228765-1-ast@fiberby.net/
> 
> Asbjørn Sloth Tønnesen (4):
>   net: sparx5: flower: only do lookup if fragment flags are set
>   net: sparx5: flower: add extack to
>     sparx5_tc_flower_handler_control_usage()
>   net: sparx5: flower: remove goto in
>     sparx5_tc_flower_handler_control_usage()
>   net: sparx5: flower: check for unsupported control flags
> 
>  .../microchip/sparx5/sparx5_tc_flower.c       | 20 +++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> --
> 2.43.0
>

For the series:

Reviewed-by: Daniel Machon <daniel.machon@...rochip.com>
Tested-by: Daniel Machon <daniel.machon@...rochip.com>