netdev - Re: [REGRESSION] sk_memory_allocated counter leaking on aarch64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <005e8085-e36b-4112-be95-8d3475d0c524@app.fastmail.com>
Date: Wed, 24 Apr 2024 14:39:24 +0100
From: "Jonathan Heathcote" <mail@...et.co.uk>
To: "Eric Dumazet" <edumazet@...gle.com>,
 "Jonathan Heathcote" <jonathan.heathcote@....co.uk>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>,
 "Jonathan Heathcote" <jonathan.heathcote@....co.uk>
Subject: Re: [REGRESSION] sk_memory_allocated counter leaking on aarch64

>> <<<garbled HTML email here>>>

My apologies for the email mess. Corporate Outlook is a bit of a disaster. Replying via my personal email rather than jonathan.heathcote@....co.uk...

>> I'm very sorry but I won't be able to give this a try until Wednesday next week (I'm currently working part time) but I'll give this a go first-thing. Thank you very much for your swift response!
>
> SGTM, I rewrote the patch to remove the not needed
> preempt_disable()/preempt_enable()
>
> I will test it soon.
>
> diff --git a/include/net/sock.h b/include/net/sock.h
> index 
> f57bfd8a2ad2deaedf3f351325ab9336ae040504..bae62604c5ffc8a3ecbe3e996b87c9fb25914c0f
> 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> ...snip...

I've finally had chance to test out the patch in 3584718 and confirm that it fixes the problem for me. Thanks very much for the swift fix!

Cheers,

Jonathan Heathcote