netdev - RE: [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB46105E83E5597982F1EF02C9F3102@DM6PR11MB4610.namprd11.prod.outlook.com>
Date: Wed, 24 Apr 2024 13:49:09 +0000
From: "Kwapulinski, Piotr" <piotr.kwapulinski@...el.com>
To: Jiri Pirko <jiri@...nulli.us>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "horms@...nel.org"
	<horms@...nel.org>, "Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
	"Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>, "Glaza, Jan"
	<jan.glaza@...el.com>
Subject: RE: [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610
 device

>>-----Original Message-----
>>From: Jiri Pirko <jiri@...nulli.us> 
>>Sent: Monday, April 22, 2024 4:26 PM
>>To: Kwapulinski, Piotr <piotr.kwapulinski@...el.com>
>>Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; horms@...nel.org; Wyborny, Carolyn <carolyn.wyborny@...el.com>; Jagielski, Jedrzej <jedrzej.jagielski@...el.com>; Glaza, Jan <jan.glaza@...el.com>
>>Subject: Re: [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device
>>
>>Mon, Apr 22, 2024 at 03:06:11PM CEST, piotr.kwapulinski@...el.com wrote:
>>
>>[...]
>>
>>
>>>diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h 
>>>b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>>index 559b443..ea6df1e 100644
>>>--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>>+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>>@@ -1,5 +1,5 @@
>>> /* SPDX-License-Identifier: GPL-2.0 */
>>>-/* Copyright(c) 1999 - 2018 Intel Corporation. */
>>>+/* Copyright(c) 1999 - 2024 Intel Corporation. */
>>> 
>>> #ifndef _IXGBE_H_
>>> #define _IXGBE_H_
>>>@@ -20,6 +20,7 @@
>>> #include "ixgbe_type.h"
>>> #include "ixgbe_common.h"
>>> #include "ixgbe_dcb.h"
>>>+#include "ixgbe_e610.h"
>>> #if IS_ENABLED(CONFIG_FCOE)
>>> #define IXGBE_FCOE
>>> #include "ixgbe_fcoe.h"
>>>@@ -28,7 +29,6 @@
>>> #include <linux/dca.h>
>>> #endif
>>> #include "ixgbe_ipsec.h"
>>>-
>>
>>Leftover hunk?
>Will do
I think it's better eventually to remove this blank line. What do you think ?
Thanks
Piotr