netdev - Re: [PATCH net-next v6 07/11] net/smc: register loopback-ism into SMC-D device list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23cff564-a65c-4db6-a386-2a7e56be84c8@linux.ibm.com>
Date: Thu, 25 Apr 2024 15:29:00 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Wenjia Zhang <wenjia@...ux.ibm.com>, Wen Gu <guwen@...ux.alibaba.com>,
        twinkler@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com,
        agordeev@...ux.ibm.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, jaka@...ux.ibm.com
Cc: borntraeger@...ux.ibm.com, svens@...ux.ibm.com, alibuda@...ux.alibaba.com,
        tonylu@...ux.alibaba.com, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6 07/11] net/smc: register loopback-ism into
 SMC-D device list



On 25.04.24 13:29, Wenjia Zhang wrote:
>> +    if (!smcd->pnetid[0]) {
>> +        fentry = list_first_entry_or_null(&smcd_dev_list.list,
>> +                          struct smcd_dev, list);
>> +        if (fentry && smc_ism_is_loopback(fentry))
>> +            list_add(&smcd->list, &fentry->list);
>> +        else
>> +            list_add(&smcd->list, &smcd_dev_list.list);
>> +    } else {
>>           list_add_tail(&smcd->list, &smcd_dev_list.list);
>> -    else
>> -        list_add(&smcd->list, &smcd_dev_list.list);
>> +    }
> 
> Nit: here the pair of curly brackets are unnecessary.

Actually
https://www.kernel.org/doc/html/latest/process/coding-style.html#codingstyle
tells you to use those braces.