netdev - Re: [PATCH net-next v2 1/6] net: tn40xx: add pci driver for Tehuti Networks TN40xx chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240425.223752.1359016853102318865.fujita.tomonori@gmail.com>
Date: Thu, 25 Apr 2024 22:37:52 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: andrew@...n.ch
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, horms@...nel.org
Subject: Re: [PATCH net-next v2 1/6] net: tn40xx: add pci driver for Tehuti
 Networks TN40xx chips

Hi,

On Thu, 25 Apr 2024 14:54:09 +0200
Andrew Lunn <andrew@...n.ch> wrote:

>> +#define TN40_DRV_VERSION "0.3.6.17.2"
> 
> A version is generally a bad idea. What does this version even mean,
> given that you are re-writting the driver? You might as well call it
> 0.0.0.0.0.

makes sense.

> We recommend that for ethtool, you leave the version field
> untouched. The core will then fill it with the kernel version. That
> version makes sense, since it gives you both the driver and the kernel
> around it.

Understood. I'll remove the driver version in v3.


thanks,