netdev - Re: [PATCH net-next v12 09/15] net: stmmac: dwmac-loongson: Add phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZipqaHivDaK/FJAs@shell.armlinux.org.uk>
Date: Thu, 25 Apr 2024 15:36:24 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Yanteng Si <siyanteng@...ngson.cn>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
	alexandre.torgue@...s.st.com, joabreu@...opsys.com,
	fancer.lancer@...il.com, Jose.Abreu@...opsys.com,
	chenhuacai@...nel.org, guyinggang@...ngson.cn,
	netdev@...r.kernel.org, chris.chenfeiyang@...il.com,
	siyanteng01@...il.com
Subject: Re: [PATCH net-next v12 09/15] net: stmmac: dwmac-loongson: Add
 phy_interface for Loongson GMAC

On Thu, Apr 25, 2024 at 09:06:12PM +0800, Yanteng Si wrote:
> The mac_interface of gmac is PHY_INTERFACE_MODE_RGMII_ID.

No it isn't!

> +	plat->phy_interface = PHY_INTERFACE_MODE_RGMII_ID;

You don't touch mac_interface here. Please read the big comment I put
in include/linux/stmmac.h above these fields in struct
plat_stmmacenet_data to indicate what the difference between
mac_interface and phy_interface are, and then correct which-ever
of the above needs to be corrected.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!