netdev - Re: [PATCH net-next v12 00/15] stmmac: Add Loongson platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21325271-95bc-41b9-8f9e-53b744369e79@loongson.cn>
Date: Fri, 26 Apr 2024 12:55:34 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v12 00/15] stmmac: Add Loongson platform support

Hi Serge,

在 2024/4/25 21:19, Serge Semin 写道:
>> v12:
>> * The biggest change is the re-splitting of patches.
>> * Add a "gmac_version" in loongson_data, then we only
>>    read it once in the _probe().
>> * Drop Serge's patch.
>> * Rebase to the latest code state.
>> * Fixed the gnet commit message.
> V11 review hasn't finished yet. You posted a question to me just four
> hours ago, waited for an answer a tiny bit and decided to submit v12.
> Really, what the rush for? Do you expect the reviewer to react in an
> instant?

I'm sorry. It's my fault.


I did this because I didn't want to repeat the v8 process, we talked 
about v8 for

two months, after I collected all the comments and changed the code, a 
lot of

changes happened, and I seemed to misunderstand the comments about patch

splitting, which made v9-v11 look bad.


v12 is actually still based on v8, but it's just resplit the patches 
again, maybe

it's easier to review,

>
> Please understand, the review process isn't a quick-road process. The
> most of the maintainers and reviewers have their own jobs and can't
> react just at the moment you want it or need it. It's better to

Yes, I quite agree with you. In fact, we have been working together 
happily for

almost a year. I appreciate your patience. With your help, this patch 
set has

gotten better and better since the beginning.

> collect all the review comments, wait for all questions being answered
> (ping the person you need if you waited long enough) and resubmit the

Yes, I understand, because I also do some kernel document translation in my

spare time, and I understand this very well.

> series with all the notes taken into account. Needlessly rushing and
> spamming out the maintainers inboxes with your series containing just
> a part of the requested changes, won't help you much but will likely
> irritate the reviewers.
Ok, I will reduce the frequency of my emails unless all comments are 
clearly answered.
>
> What do you expect me to do now? Move on with v11 review? Copy my
> questions to v12 and continue the discussion here? By not waiting for
> all the discussions done you made the my life harder. What was the
> point? Sigh...

v11 is not much different from v12, except that it removes your patch 
and then

resplits the patch, which improves the review efficiency to some extent.


loongson_dwmac_config_multi_msi() is the only comment left that didn't 
end in

v11. I originally wanted to include this question in the cover letter of 
v12, but I

did send it in a hurry and lost it. I'm sorry about that, let me copy 
this question

to v12.


Thanks,

Yanteng